Skip to content

include source-watcher in install.yaml manifests#5881

Merged
matheuscscp merged 1 commit into
fluxcd:mainfrom
tmmorin:include-source-watcher-in-install-manifests
May 6, 2026
Merged

include source-watcher in install.yaml manifests#5881
matheuscscp merged 1 commit into
fluxcd:mainfrom
tmmorin:include-source-watcher-in-install-manifests

Conversation

@tmmorin

@tmmorin tmmorin commented May 6, 2026

Copy link
Copy Markdown
Contributor

The source-watcher controller is currently not included in the manifest.yaml which is part of a release bundle.

Example: https://github.com/fluxcd/flux2/releases/download/v2.8.6/install.yaml

This PR updates the ./manifests/install kustomization to include the source-watcher, so that an installation done with the install.yaml which is part of a release will include this controller.

@matheuscscp

matheuscscp commented May 6, 2026

Copy link
Copy Markdown
Member

In flux bootstrap or flux install you need to use --components-extra=source-watcher.

@matheuscscp matheuscscp closed this May 6, 2026
@tmmorin

tmmorin commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

In flux bootstrap or flux install you need to use --components-extra=source-watcher.

Our use case is that we directly consume the manifests from a kustomization.yaml (used by a Kustomization to let flux self-manage itself):

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - https://github.com/fluxcd/flux2/releases/download/v2.8.6/install.yaml

I honestly thought that it was a simple omission to not have this specific source-watcher controller as part of the install.yaml, because it's the only one missing.

Also, the controllers which can be enabled with flux (bootstrap|install) --components-extra=... seem to be all already part of install.yaml, except the source-watcher.

@matheuscscp matheuscscp reopened this May 6, 2026
@matheuscscp

matheuscscp commented May 6, 2026

Copy link
Copy Markdown
Member

You have a good point!

@tmmorin tmmorin force-pushed the include-source-watcher-in-install-manifests branch from 3c4d42a to 626bb58 Compare May 6, 2026 15:42
@matheuscscp matheuscscp added bug Something isn't working backport:release/v2.8.x To be backported to release/v2.8.x labels May 6, 2026
matheuscscp
matheuscscp approved these changes May 6, 2026
View reviewed changes

@matheuscscp matheuscscp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Thanks for the fix, @tmmorin!

@matheuscscp matheuscscp merged commit abb86f1 into fluxcd:main May 6, 2026
7 checks passed
@fluxcdbot

fluxcdbot commented May 6, 2026

Copy link
Copy Markdown
Member

Successfully created backport PR for release/v2.8.x:

@fluxcdbot fluxcdbot mentioned this pull request May 6, 2026
Merged
This was referenced Jul 1, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matheuscscp matheuscscp matheuscscp approved these changes

Assignees

No one assigned

Labels

backport:release/v2.8.x To be backported to release/v2.8.x bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmmorin @matheuscscp @fluxcdbot