Repository navigation
Commit f8c8551
authored
fix(widgets): dismiss open RawTooltip on Escape key (WCAG 1.4.13) (flutter#192966)
## Description
Improves `RawTooltip` keyboard accessibility (`WCAG 1.4.13 Dismissible`,
http://b/463905826):
- **`RawTooltip` `Escape` key dismissal**: Registers a
`HardwareKeyboard` handler in `RawTooltipState` that dismisses open
tooltips on `LogicalKeyboardKey.escape` (`KeyDownEvent`) and consumes
the key event when a tooltip is open, preventing `Escape` from
prematurely closing parent modal dialogs (such as `DatePickerDialog`)
while a tooltip is displayed.
- *(Note: The accompanying Material changes for `Autocomplete`,
`DrawerHeader`, and `TooltipThemeData.ignorePointer` will be submitted
separately to `packages/material_ui` in `flutter/packages` per
[flutter#188444](flutter#188444
Fixes http://b/463905826
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.1 parent 9dc1569 commit f8c8551
2 files changed
Lines changed: 79 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
591 | 591 | | |
592 | 592 | | |
593 | 593 | | |
| 594 | + | |
594 | 595 | | |
595 | 596 | | |
596 | 597 | | |
597 | 598 | | |
598 | 599 | | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
599 | 611 | | |
600 | 612 | | |
601 | 613 | | |
| |||
808 | 820 | | |
809 | 821 | | |
810 | 822 | | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
811 | 832 | | |
812 | 833 | | |
813 | 834 | | |
| |||
873 | 894 | | |
874 | 895 | | |
875 | 896 | | |
| 897 | + | |
876 | 898 | | |
877 | 899 | | |
878 | 900 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3219 | 3219 | | |
3220 | 3220 | | |
3221 | 3221 | | |
| 3222 | + | |
| 3223 | + | |
| 3224 | + | |
| 3225 | + | |
| 3226 | + | |
| 3227 | + | |
| 3228 | + | |
| 3229 | + | |
| 3230 | + | |
| 3231 | + | |
| 3232 | + | |
| 3233 | + | |
| 3234 | + | |
| 3235 | + | |
| 3236 | + | |
| 3237 | + | |
| 3238 | + | |
| 3239 | + | |
| 3240 | + | |
| 3241 | + | |
| 3242 | + | |
| 3243 | + | |
| 3244 | + | |
| 3245 | + | |
| 3246 | + | |
| 3247 | + | |
| 3248 | + | |
| 3249 | + | |
| 3250 | + | |
| 3251 | + | |
| 3252 | + | |
| 3253 | + | |
| 3254 | + | |
| 3255 | + | |
| 3256 | + | |
| 3257 | + | |
| 3258 | + | |
| 3259 | + | |
| 3260 | + | |
| 3261 | + | |
| 3262 | + | |
| 3263 | + | |
| 3264 | + | |
| 3265 | + | |
| 3266 | + | |
| 3267 | + | |
| 3268 | + | |
| 3269 | + | |
| 3270 | + | |
| 3271 | + | |
| 3272 | + | |
| 3273 | + | |
| 3274 | + | |
| 3275 | + | |
| 3276 | + | |
| 3277 | + | |
| 3278 | + | |
3222 | 3279 | | |
3223 | 3280 | | |
3224 | 3281 | | |
| |||
0 commit comments