Repository navigation
Commit e65eafa
authored
[Android] Let the raster thread use every core of a chip without little cores (flutter#195071)
`CPUSpeedTracker` counts the CPUs with the lowest `cpuinfo_max_freq` as
efficiency cores, and the raster thread is set to the other cores
(`kNotEfficiency`, renamed `kNotLittle` in this PR). On a chip without
little cores, those are full-size cores. On the Snapdragon 8 Elite and 8
Elite Gen 5 (two prime and six performance Oryon cores) the raster
thread only gets the two prime cores. They are mostly idle, so raster
frames start at the cluster's lowest frequency. See flutter#195070 for
measurements.
This change also reads `/sys/devices/system/cpu/cpuN/cpu_capacity`, the
kernel's rating of each CPU, scaled so that the fastest is 1024. When
every CPU has a capacity and none is below half of the fastest, the chip
has no little cores, and `kNotLittle` is every core.
- Why half: little cores rate well below it. Upstream SM8650 device
trees put the Cortex-A520 at about 37% of the X4 at their top
frequencies. The SM8850's performance cores are at 762 of 1024.
- Equal capacities, or a CPU without one, change nothing. A kernel
without capacity data reports 1024 for every CPU.
- Other affinities do not change. `kEfficiency` is still the slowest
group, so background threads stay off the prime cores.
- `kNotEfficiency` is renamed `kNotLittle`, since on these chips it
includes the efficiency cores. Each `CpuAffinity` value's doc says which
cores it covers, and that performance and efficiency there are speed
groups, not the industry's core types.
- Chips with little cores (Snapdragon 8 Gen 1–3, Tensor, Exynos 2400)
should keep the current set. I have only read the capacities of the
SM8850.
- Other chips without little cores also get every core. Examples:
Dimensity 9300/9400 (the slowest group is four Cortex-A720), Snapdragon
8s Gen 4, and Snapdragon 8 Elite Gen 6. On the 8 Elite Gen 6 the six
performance cores report two top frequencies (4.03 and 3.74 GHz), so
today three of them count as efficiency cores. I have not measured these
chips.
- On the Dimensity 9600 Pro (2 × C2-Ultra at 4.55 GHz, 3 × C2-Pro at
4.35 GHz, 3 × C2-Pro at 3.1 GHz), the 3.1 GHz cores should rate near
half, so it may go either way. Either way the raster thread keeps at
least the five cores it gets today.
This keeps the current design and only widens it where the capacities
are clear. A chip whose performance cores rate below half of its prime
cores would still leave the raster thread on the prime cores. The more
general fix would be to stop pinning the raster thread, as Android does
not pin a native app's RenderThread. That needs measurements on the
devices that flutter-team-archive/engine#45673
and flutter#153690 were about, so this change leaves it out.
Tests: three new `CpuAffinity` tests in `fml_unittests`. `NoLittleCores`
fails without this change. I ran the `CpuAffinity` tests against the
changed files in a standalone build with clang++ and g++, not in a full
engine build. On an SM8850 phone, setting the raster threads to every
core from the app (the same result as this change) gave the numbers in
flutter#195070. I have not tested a custom engine build on the device.
Fixes flutter#195070
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md1 parent 5253d01 commit e65eafa
5 files changed
Lines changed: 129 additions & 22 deletions
File tree
- engine/src/flutter
- fml
- platform/android
- shell/platform/android
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
35 | 60 | | |
36 | 61 | | |
37 | 62 | | |
| |||
60 | 85 | | |
61 | 86 | | |
62 | 87 | | |
63 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
64 | 98 | | |
65 | 99 | | |
66 | 100 | | |
| |||
80 | 114 | | |
81 | 115 | | |
82 | 116 | | |
83 | | - | |
84 | | - | |
| 117 | + | |
| 118 | + | |
85 | 119 | | |
86 | 120 | | |
87 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
18 | 24 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
| 25 | + | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | | - | |
| 29 | + | |
| 30 | + | |
26 | 31 | | |
27 | 32 | | |
28 | | - | |
| 33 | + | |
29 | 34 | | |
30 | 35 | | |
31 | | - | |
32 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
33 | 44 | | |
34 | 45 | | |
35 | 46 | | |
| |||
55 | 66 | | |
56 | 67 | | |
57 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
58 | 74 | | |
59 | 75 | | |
60 | 76 | | |
| |||
83 | 99 | | |
84 | 100 | | |
85 | 101 | | |
86 | | - | |
| 102 | + | |
87 | 103 | | |
88 | 104 | | |
89 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
35 | 88 | | |
36 | 89 | | |
37 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
30 | | - | |
31 | | - | |
32 | | - | |
| 32 | + | |
| 33 | + | |
33 | 34 | | |
34 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
0 commit comments