Skip to content

Commit 7b23f12

Browse files
authored
Mitigate snapshot race in 3D transform test by reducing loop density (flutter#193936)
Part of flutter#193689 Pre-requisite for flutter#192937 This PR reduces the angular sampling step in the 3D perspective transform test to eliminate rapid snapshot cascades and stabilize the `Mac framework_tests_impeller` shard. While preparing flutter#192937, `Mac framework_tests_impeller` failed repeatedly but not deterministically on `3D transform renders the same with or without needsCompositing` in `packages/flutter/test/widgets/transform_test.dart`. That PR recycles the host buffer between snapshots to fix the memory leak. This test takes back-to-back snapshots in a tight loop, which has an increased likelihood of a GPU race condition when host buffers are recycled. The chance of a problem increases with number of loop iterations, so this PR just reduces the number of loops in `transform_test.dart` by increasing the angle increment from `0.01` to `0.05`. I feel this still achieves the purpose of the test while reducing flakiness related to host buffer reuse. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 39d6661 commit 7b23f12

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎packages/flutter/test/widgets/transform_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ void main() {
535535
testWidgets(
536536
'3D transform renders the same with or without needsCompositing',
537537
(WidgetTester tester) async {
538-
for (double angle = 0; angle <= math.pi / 4; angle += 0.01) {
538+
for (double angle = 0; angle <= math.pi / 4; angle += 0.05) {
539539
await tester.pumpWidget(RepaintBoundary(child: generateTransform(true, angle)));
540540
final RenderBox renderBox = tester.binding.renderView.child!;
541541
final layer = renderBox.debugLayer! as OffsetLayer;

0 commit comments

Comments
 (0)