You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1b9ee1a
Browse filesBrowse the repository at this point in the historyBrowse files
[CP-beta][web] Make resize and render atomic on the shared offscreen surface (flutter#195839)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Cherry-pick of flutter#194401.
### Issue Link:
flutter#185034
### Impact Description:
In multi-view Flutter Web apps, views rendered at the same time race on a shared offscreen surface and end up with the wrong canvas size, clipping or overflowing their host HTML containers. Skwasm's `Image.toByteData` uses the same surface and has the same problem.
This is a regression since Flutter 3.41 (flutter#179473) that affects deployed multi-view web apps on both CanvasKit and Skwasm and has been blocking production apps from upgrading past 3.38.
### Changelog Description:
[flutter/185034](flutter#185034): When rendering multiple views on the web, canvases may fail to match their host container dimensions.
### Workaround:
None.
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
Follow the repro steps in flutter#185034, or run the new tests in `engine/src/flutter/lib/web_ui/test/ui/multi_view_sizing_test.dart`.
0 commit comments