Skip to content

Commit 9007e14

Browse files
authored
ci: add mac verify binaries workflow (flutter#190010)
- Extracts engine change detection logic from `wait-for-engine-build` into a reusable `has-engine-changes` composite action. - Introduces a new `mac-verify-binaries` GitHub Actions workflow. - Fixes an empty string check for `PUSH_BEFORE_SHA` in the `wait-for-engine-build` action. fixes: flutter#189995
1 parent 849e8a2 commit 9007e14

3 files changed

Lines changed: 105 additions & 29 deletions

File tree

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
name: 'Has Engine Changes'
2+
description: 'Checks if there are any engine changes in the current branch'
3+
outputs:
4+
changed:
5+
description: "Returns 'true' if there are engine changes, 'false' otherwise"
6+
value: ${{ steps.check.outputs.changed }}
7+
runs:
8+
using: "composite"
9+
steps:
10+
- name: Check Engine Changes
11+
id: check
12+
shell: bash
13+
env:
14+
EVENT_NAME: ${{ github.event_name }}
15+
PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
16+
MERGE_GROUP_BASE_SHA: ${{ github.event.merge_group.base_sha }}
17+
PUSH_BEFORE_SHA: ${{ github.event.before }}
18+
run: |
19+
EMPTY_SHA="0000000000000000000000000000000000000000"
20+
if [ "$EVENT_NAME" = "pull_request" ]; then
21+
BASE_REF="$PR_BASE_SHA"
22+
elif [ "$EVENT_NAME" = "merge_group" ]; then
23+
BASE_REF="$MERGE_GROUP_BASE_SHA"
24+
elif [ "$EVENT_NAME" = "push" ] && [ -n "$PUSH_BEFORE_SHA" ] && [ "$PUSH_BEFORE_SHA" != "$EMPTY_SHA" ]; then
25+
BASE_REF="$PUSH_BEFORE_SHA"
26+
else
27+
if git show-ref --verify --quiet refs/remotes/upstream/master; then
28+
BASE_REF="upstream/master"
29+
else
30+
BASE_REF="origin/master"
31+
fi
32+
fi
33+
34+
echo "Comparing against base SHA: $BASE_REF"
35+
36+
CHANGED_FILES=$(.github/scripts/git_files_changed.sh "$BASE_REF")
37+
echo "Changed files in this branch:"
38+
echo "$CHANGED_FILES"
39+
40+
if [ "$(printf '%s\n' "$CHANGED_FILES" | .github/scripts/did_engine_change.sh)" = "true" ]; then
41+
echo "Engine files changed."
42+
echo "changed=true" >> "$GITHUB_OUTPUT"
43+
else
44+
echo "No engine files changed."
45+
echo "changed=false" >> "$GITHUB_OUTPUT"
46+
fi

‎.github/actions/wait-for-engine-build/action.yml‎

Lines changed: 5 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -17,40 +17,16 @@ runs:
1717
steps:
1818
- name: Check Engine Changes
1919
id: check_engine
20+
uses: ./.github/actions/has-engine-changes
21+
22+
- name: Log wait requirement
23+
if: steps.check_engine.outputs.changed == 'true'
2024
shell: bash
2125
env:
22-
EVENT_NAME: ${{ github.event_name }}
23-
PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
24-
MERGE_GROUP_BASE_SHA: ${{ github.event.merge_group.base_sha }}
25-
PUSH_BEFORE_SHA: ${{ github.event.before }}
2626
INPUTS_CHECK_NAME: ${{ inputs.check-name }}
2727
INPUTS_CHECK_REGEXP: ${{ inputs.check-regexp }}
2828
run: |
29-
# 1. Determine local base tracking SHA
30-
if [ "$EVENT_NAME" = "pull_request" ]; then
31-
BASE_REF="$PR_BASE_SHA"
32-
elif [ "$EVENT_NAME" = "merge_group" ]; then
33-
BASE_REF="$MERGE_GROUP_BASE_SHA"
34-
elif [ "$EVENT_NAME" = "push" ] && [ "$PUSH_BEFORE_SHA" != "0000000000000000000000000000000000000000" ]; then
35-
BASE_REF="$PUSH_BEFORE_SHA"
36-
else
37-
BASE_REF="origin/master"
38-
fi
39-
40-
echo "Comparing against base SHA: $BASE_REF"
41-
42-
# 2. Get the changed files using the helper script
43-
CHANGED_FILES=$(.github/scripts/git_files_changed.sh "$BASE_REF")
44-
echo "Changed files in this branch:"
45-
echo "$CHANGED_FILES"
46-
47-
# 3. Check if any file matches engine pattern using the helper script:
48-
if [ "$(printf '%s\n' "$CHANGED_FILES" | .github/scripts/did_engine_change.sh)" = "true" ]; then
49-
echo "Engine file changed - forced to wait for check-name: '${INPUTS_CHECK_NAME}', check-regexp: '${INPUTS_CHECK_REGEXP}'"
50-
echo "changed=true" >> "$GITHUB_OUTPUT"
51-
else
52-
echo "changed=false" >> "$GITHUB_OUTPUT"
53-
fi
29+
echo "Engine file changed - forced to wait for check-name: '${INPUTS_CHECK_NAME}', check-regexp: '${INPUTS_CHECK_REGEXP}'"
5430
5531
# Note: Use the Cocoon wait-for-tests action to poll the Cocoon API.
5632
- name: Wait for test check-in
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
name: Mac Verify Binaries
2+
3+
on:
4+
pull_request:
5+
branches: [master]
6+
merge_group:
7+
branches: [master]
8+
9+
jobs:
10+
check-engine-changes:
11+
permissions:
12+
contents: read
13+
runs-on: ubuntu-latest
14+
outputs:
15+
changed: ${{ steps.check.outputs.changed }}
16+
steps:
17+
- name: Checkout code
18+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
19+
with:
20+
fetch-depth: 0
21+
ref: ${{ github.event.pull_request.head.sha || github.sha }}
22+
persist-credentials: false
23+
24+
- name: Check Engine Changes
25+
id: check
26+
uses: ./.github/actions/has-engine-changes
27+
28+
Mac_arm64_verify_binaries:
29+
needs: check-engine-changes
30+
if: needs.check-engine-changes.outputs.changed == 'true'
31+
permissions:
32+
contents: read
33+
runs-on: macos-latest
34+
timeout-minutes: 130
35+
36+
steps:
37+
- name: Checkout code
38+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
39+
with:
40+
fetch-depth: 0
41+
ref: ${{ github.event.pull_request.head.sha || github.sha }}
42+
persist-credentials: false
43+
44+
- name: Wait for Engine Build
45+
uses: ./.github/actions/wait-for-engine-build
46+
with:
47+
github-token: ${{ secrets.GITHUB_TOKEN }}
48+
check-name: 'Mac mac_host_engine'
49+
50+
- uses: ./.github/actions/composite-flutter-setup
51+
52+
- name: Run verify_binaries_pre_codesigned
53+
run: |
54+
SHARD=verify_binaries_pre_codesigned LUCI_CI=true dart --enable-asserts dev/bots/test.dart

0 commit comments

Comments
 (0)