Skip to content

Conversation

@HakkyuKim
Copy link
Contributor

@HakkyuKim HakkyuKim commented Mar 25, 2021

⚠️ : This pr should be merged after #61

This change caches plugin build sources so that plugins are rebuilt only when it needs to.

I've tested for following cases:

  • adding new plugin dependency in pubspec.yaml
  • removing existing plugin dependency in pubspec.yaml
  • changing existing plugin version in pubspec.yaml
  • changing the plugin source code when the plugin project is listed as a path dependency in pubspec.yaml

The cached sources are:

  • inputs:

    • files in engine/common/client_wrappers
    • files in engine/common/public
    • engine/tizen-<arch>-<mode>/libflutter_tizen.so
    • rootstrap/wearable-<api-version>-<type>.flutter.xml
    • files in tizen/inc, tizen/src, and the project_def.prop file
  • outputs: the compiled plugin .so files

@HakkyuKim HakkyuKim requested a review from a team March 25, 2021 08:32
@HakkyuKim
Copy link
Contributor Author

HakkyuKim commented Mar 25, 2021

I may have to add some more input sources, for example engine binaries and source files

@HakkyuKim
Copy link
Contributor Author

I may have to add some more input sources, for example engine binaries and source files

done

@HakkyuKim HakkyuKim requested a review from swift-kim March 31, 2021 10:26
@HakkyuKim HakkyuKim merged commit 2c6bb0a into flutter-tizen:master Apr 2, 2021
@swift-kim swift-kim mentioned this pull request Jun 26, 2021
18 tasks
@HakkyuKim HakkyuKim deleted the plugin-build-caching branch October 8, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants