embedding/csharp: Add StandardMessageCodec #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonyoungChoi
force-pushed
the
std-msg-codec
branch
from
dfc497f to
f38c47b
Compare
WonyoungChoi
force-pushed
the
std-msg-codec
branch
from
3070e94 to
8f5e916
Compare
swift-kim
reviewed
Nov 3, 2021
Comment on lines
-54
to
-56
| /// <summary> | ||
| /// Sends a binary message to the given channel. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
Is the documentation automatically inherited from IBinaryMessenger?
Contributor
Author
There was a problem hiding this comment.
DefaultBinaryMessenger is an internal class. The comments for public documentation are not necessary.
embedding/csharp/Tizen.Flutter.Embedding.Tests/Channels/StandardMessageCodecTests.cs
Outdated
Show resolved
Hide resolved
embedding/csharp/Tizen.Flutter.Embedding.Tests/Channels/StandardMessageCodecTests.cs
Outdated
Show resolved
Hide resolved
…rdMessageCodecTests.cs Co-authored-by: Swift Kim <[email protected]>
WonyoungChoi
force-pushed
the
std-msg-codec
branch
from
4bf8f44 to
87c9e7f
Compare
swift-kim
approved these changes
Nov 3, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardMessageCodecand tests.StandardMethodCodeclater.