Download engine artifacts in dart code #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonyoungChoi
changed the title
WonyoungChoi
force-pushed
the
cached-tizen-artifacts
branch
from
185bcf4 to
9ddcb5e
Compare
- Download tizen engine artifacts by using ArtifactUpdater - Download gen_snapshot(.exe) from the android's url - Move the location of tizen artifacts to `flutter/bin/cache/artifacts/engine` - Remove tizen_artifacts.dart The artifacts should be uploaded to the github releases in the following form: - tizen-common.zip - tizen-x86-debug.zip - tizen-arm-debug.zip - tizen-arm-profile.zip - tizen-arm-release.zip - tizen-arm64-debug.zip - tizen-arm64-profile.zip - tizen-arm64.release.zip
WonyoungChoi
force-pushed
the
cached-tizen-artifacts
branch
from
9ddcb5e to
71389e3
Compare
WonyoungChoi
changed the title
swift-kim
reviewed
Jun 29, 2021
Co-authored-by: Swift Kim <[email protected]>
Co-authored-by: Swift Kim <[email protected]>
Co-authored-by: Swift Kim <[email protected]>
swift-kim
approved these changes
Jul 2, 2021
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
Thank you for your hard work!
| '/_apis/build/builds/$buildId/artifacts?artifactName=release'; | ||
|
|
||
| final http.Response response = await http.get(Uri.parse(azureRestUrl)); | ||
| if (response.statusCode == 200) { |
Member
There was a problem hiding this comment.
I searched for the keyword "response.statusCode" in flutter_tools and it seemed more common to use predefined constants:
Suggested change
| if (response.statusCode == 200) { | |
| if (response.statusCode == HttpStatus.ok) { |
Member
|
The new release (https://github.com/flutter-tizen/engine/releases/tag/a7ea781) has passed the store verification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #77
flutter/bin/cache/artifacts/engineThe artifacts should be uploaded to the github releases in the following form:
Use following two environment variables:
AZURE_BUILD_IDto download artifacts from the Azure pipeline's artifactsTIZEN_ENGINE_BASE_URLto override the default urlhttps://github.com/flutter-tizen/engine/releasesAZURE_BUILD_IDtakes precedence overTIZEN_ENGINE_BASE_URL