Add a format checker to the CI pipeline #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
force-pushed
the
ci-format-2
branch
4 times, most recently
from
57a8f9f to
1f8c835
Compare
I didn't know there was this, What do you think about replacing the plugin repository |
Member
Author
|
@bbrto21 The first-party plugins also follow the Google style (https://github.com/flutter/plugins/blob/master/.clang-format) so I think we can leave as it is. |
|
@swift-kim Oh, thank you for checking! |
Closed
swift-kim
added a commit
that referenced
this pull request
Jun 7, 2021
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Format gn files * Format C/C++ files * Update azure-pipelines.yml * Rename the format job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatjob to the CI pipeline.The linter job will be added in the future.(The lint warning/errors will not be analyzed by the CI.).clang-formatfile).For maintainers: The Chromium C/C++ style is slightly different from the Google C/C++ style, but you don't need any special configuration if everything works correctly. clang-format and the VS Code extension should just work out of the box. They will find the
.clang-formatfile from the repository root automatically.To manually analyze code formatting, you can use either:
check_tidy.py --dir shell/platform/tizen)ci/format.sh)git remote add upstream https://github.com/flutter/engine.git