Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[tool] Fix false positives in update-exceprts - #6950

Merged
stuartmorgan-g merged 1 commit into
flutter-team-archive:mainfrom
stuartmorgan-g:excerpt-false-positive-fix
Jan 13, 2023
Merged

[tool] Fix false positives in update-exceprts#6950
stuartmorgan-g merged 1 commit into
flutter-team-archive:mainfrom
stuartmorgan-g:excerpt-false-positive-fix

Conversation

@stuartmorgan-g

@stuartmorgan-g stuartmorgan-g commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

When determining whether or not to fail with --fail-on-change, only look at .md files. In some cases, running the necessary commands (e.g., flutter pub get) may change unrelated files, causing fales positive failures. Only changed documentation files should be flagged.

Also log the specific files that were detected as changed, to aid in debugging any future false positives.

Fixes flutter/flutter#111592
Fixes flutter/flutter#111590

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[tool] Fix false positives in update-exceprts
6a5b58b 
When determining whether or not to fail with `--fail-on-change`, only
look at .md files. In some cases, running the necessary commands (e.g.,
`flutter pub get`) may change unrelated files, causing fales positive
failures. Only changed documentation files should be flagged.

Also log the specific files that were detected as changed, to aid in
debugging any future false positives.

Fixes flutter/flutter#111592
Fixes flutter/flutter#111590
@stuartmorgan-g

stuartmorgan-g commented Jan 13, 2023

Copy link
Copy Markdown
Contributor Author

Force-landing since we need to land something to green the tree due to flutter/flutter#116226

@stuartmorgan-g
stuartmorgan-g merged commit 92a5367 into flutter-team-archive:main Jan 13, 2023
@stuartmorgan-g
stuartmorgan-g deleted the excerpt-false-positive-fix branch January 13, 2023 11:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2023
@engine-flutter-autoroll
92a5367d5 [tool] Fix false positives in update-exceprts (flutter-team…
f81faf7 
…-archive/plugins#6950)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 13, 2023
@engine-flutter-autoroll
Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (#118457)
fb1a151 
* b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter-team-archive/plugins#6948)

* 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter-team-archive/plugins#6635)

* be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter-team-archive/plugins#6952)

* 92a5367d5 [tool] Fix false positives in update-exceprts (flutter-team-archive/plugins#6950)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter…
77f5ce0 
…#118457)

* b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter-team-archive/plugins#6948)

* 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter-team-archive/plugins#6635)

* be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter-team-archive/plugins#6952)

* 92a5367d5 [tool] Fix false positives in update-exceprts (flutter-team-archive/plugins#6950)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449)
8c2fdb8 
* init scaled changes

* add correct padding values for M3

* revert unneeded change

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* comment fixes

* test update

* docstring fixes

* e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter-team-archive/engine#38558) (#117779)

* Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781)

* 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter-team-archive/plugins#6889)

* 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter-team-archive/plugins#6886)

* 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter-team-archive/engine#38560) (#117783)

* 3460f34 [fuchsia] Set presentation interval (flutter-team-archive/engine#38549) (#117785)

* Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (#117788)

* 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter-team-archive/engine#38561)

* 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter-team-archive/engine#38563)

* a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter-team-archive/engine#38565) (#117790)

* Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (#117795)

* e012dc8 [Windows] Add engine builder to simplify tests (flutter-team-archive/engine#38546)

* 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (flutter-team-archive/engine#38562)

* Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797)

* fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter-team-archive/engine#38554)

* 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter-team-archive/engine#38568)

* 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter-team-archive/engine#38569) (#117799)

* 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter-team-archive/engine#38571) (#117800)

* e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter-team-archive/engine#38572) (#117802)

* af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter-team-archive/engine#38574) (#117804)

* 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter-team-archive/engine#38575) (#117805)

* d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter-team-archive/engine#38578) (#117817)

* b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter-team-archive/plugins#6892) (#117824)

* Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (#117830)

* 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter-team-archive/engine#38579)

* 9153966 [fuchsia] Bump the target API level to 11 (flutter-team-archive/engine#38544)

* b9bf51d Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter-team-archive/engine#38580) (#117832)

* Roll Flutter Engine from b9bf51d to f6ad9b6 (2 revisions) (#117834)

* 4b38736 [Impeller Scene] Import materials, load embedded textures (flutter-team-archive/engine#38577)

* f6ad9b6 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter-team-archive/engine#38581)

* 932591e Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter-team-archive/engine#38584) (#117840)

* 3d8c5ef Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter-team-archive/engine#38585) (#117846)

* Roll Flutter Engine from 3d8c5ef to a7decc3 (2 revisions) (#117856)

* 3470fa8 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter-team-archive/engine#38586)

* a7decc3 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter-team-archive/engine#38587)

* 0a2029c Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter-team-archive/engine#38588) (#117858)

* 5fe7d5b Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter-team-archive/engine#38591) (#117863)

* e5d605b Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter-team-archive/engine#38592) (#117865)

* 71c5f17 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter-team-archive/engine#38593) (#117868)

* 472e34c Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter-team-archive/engine#38594) (#117869)

* Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (#117875)

* 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter-team-archive/plugins#6896)

* 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter-team-archive/plugins#6901)

* e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter-team-archive/plugins#6908)

* [flutter_tools] timeline_test.dart flaky (#116667)

* contains name instead of remove last

* fix expect

* remove and expect on elements

* delete unused code

* 7e51aef Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter-team-archive/engine#38596) (#117874)

* Updated to tokens v0.150. (#117350)

* Updated to tokens v0.150.

* Updated with a reverted list_tile.dart.

* Simplify null check. (#117026)

* Simplify null check.

* Simplify null check.

* Simplify null check.

* Fix.

* Roll Flutter Engine from