Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

== override parameters are non-nullable - #6900

Merged
srawlins merged 4 commits into
flutter-team-archive:mainfrom
srawlins:nullable-equal
Jan 10, 2023
Merged

== override parameters are non-nullable#6900
srawlins merged 4 commits into
flutter-team-archive:mainfrom
srawlins:nullable-equal

Conversation

@srawlins

@srawlins srawlins commented Dec 31, 2022

Copy link
Copy Markdown
Contributor

Make operator == override parameters no-nullable.

Fixes flutter/flutter#117838

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboard Bot commented Dec 31, 2022

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g
stuartmorgan-g approved these changes Dec 31, 2022
View reviewed changes

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srawlins

srawlins commented Jan 6, 2023

Copy link
Copy Markdown
Contributor Author

@stuartmorgan I can't make heads or tails of that CI failure. Any idea?

@stuartmorgan-g

stuartmorgan-g commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

We've been having OOM flake building that target recently; I'm re-running it.

@srawlins

srawlins commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

Is there a way to force it?

@srawlins
srawlins merged commit 6a24f2d into flutter-team-archive:main Jan 10, 2023
@srawlins
srawlins deleted the nullable-equal branch January 10, 2023 15:45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2023
@engine-flutter-autoroll
6a24f2d7b == override parameters are non-nullable (flutter-team-archi…
609f195 
…ve/plugins#6900)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 11, 2023
@engine-flutter-autoroll
Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (#118317)
e697805 
* 6a24f2d7b == override parameters are non-nullable (flutter-team-archive/plugins#6900)

* b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter-team-archive/plugins#6933)

* b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter-team-archive/plugins#6902)

* 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter-team-archive/plugins#6915)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter…
e6ee8bc 
…#118317)

* 6a24f2d7b == override parameters are non-nullable (flutter-team-archive/plugins#6900)

* b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter-team-archive/plugins#6933)

* b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter-team-archive/plugins#6902)

* 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter-team-archive/plugins#6915)
esouthren added a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449)