Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[connectivity] Ignore Reachability pointer to int cast warning - #3941

Merged
stuartmorgan-g merged 1 commit into
flutter-team-archive:masterfrom
jmagman:reachability
May 20, 2021
Merged

[connectivity] Ignore Reachability pointer to int cast warning#3941
stuartmorgan-g merged 1 commit into
flutter-team-archive:masterfrom
jmagman:reachability

Conversation

@jmagman

@jmagman jmagman commented May 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Suppress Reachability dependency warning in iOS and macOS example app.

Fixes flutter/flutter#82964

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this May 20, 2021
@google-cla google-cla Bot added the cla: yes label May 20, 2021
blasten
blasten approved these changes May 20, 2021
View reviewed changes

@blasten blasten left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g

stuartmorgan-g commented May 20, 2021

Copy link
Copy Markdown
Contributor

Landing on red to fix redness

@stuartmorgan-g
stuartmorgan-g merged commit df4dea5 into flutter-team-archive:master May 20, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2021
@engine-flutter-autoroll
df4dea5 [connectivity] Ignore Reachability pointer to int cast warning (
293b2fb 
flutter-team-archive/plugins#3941)
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 20, 2021
Merged
7 of 11 tasks
@jmagman
jmagman deleted the reachability branch May 20, 2021 18:15
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman @fotiDim
[connectivity] Ignore Reachability pointer to int cast warning (flutt…
2a59ad6 
…er-team-archive#3941)

Suppress Reachability dependency warning in iOS and macOS example app.

Fixes flutter/flutter#82964
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@blasten blasten blasten approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

cla: yes p: connectivity platform-ios platform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

connectivity plugin has Reachability analyzer error: cast to smaller integer type 'unsigned int' from 'Reachability *' [-Werror,-Wpointer-to-int-cast]

3 participants

@jmagman @stuartmorgan-g @blasten