This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Repository navigation
[url_launcher] Migrate pushRouteNameToFramework to ChannelBuffers - #3893
Merged
fluttergithubbot merged 1 commit intoMay 20, 2021
Merged
Conversation
blasten
reviewed
May 18, 2021
Comment on lines
+38
to
+43
| await tester.pump(); | ||
| await tester.pump(const Duration(seconds: 5)); |
There was a problem hiding this comment.
nit: comment about why these two vsyncs are required, and 5s is chosen
Hixie
marked this pull request as ready for review
May 18, 2021 18:33
Hixie
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2021
7 of 11 tasks
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.