This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Move camera to camera/camera#3258
Merged
mvanbeusekom merged 5 commits intoNov 10, 2020
Merged
Conversation
22 tasks
ditman
suggested changes
Nov 9, 2020
ditman
left a comment
ditman
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me.
Can you please update the pubspec.yaml of the plugin with a patch bump of the version, and the new homepage?
version: 0.5.8+15
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera
Also add an entry to the changelog describing the change? Something like:
"Moved package to camera/camera subdir, to allow for federated implementations."
This way we can republish camera/camera to pub.dev, and others with in-flight PRs will understand why we did the move.
Thanks!!
mvanbeusekom
force-pushed
the
prepare_for_federation
branch
from
November 10, 2020 06:55
8a361ba to
2f2aa20
Compare
Contributor
Author
|
@ditman, thank you for reviewing. I have processed your feedback and would appreciate it if you could give another review. |
ditman
approved these changes
Nov 10, 2020
fesp
pushed a commit
to fesp/plugins
that referenced
this pull request
Nov 11, 2020
* Move camera to camera/camera * Fix relative path after move * Rebased with master and update version * Update homepage * Skip XCTESTS for the camera/camera plugin
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* Move camera to camera/camera * Fix relative path after move * Rebased with master and update version * Update homepage * Skip XCTESTS for the camera/camera plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request prepares the camera plugin for federation by simply moving all current logic into it's own "camera" folder. A suggested by @ditman in the PR #3253 (see #3253 (comment)).
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?