This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Copy the Flutter Runner from //topaz into the engine. - #8886
Merged
chinmaygarde merged 3 commits intoMay 8, 2019
Merged
chinmaygarde merged 3 commits into
chinmaygarde merged 3 commits into
Conversation
Contributor
Author
|
After babysitting all rollers, I have verified that patches in all dependencies have been rolled into DEPS. |
Contributor
|
There are still various references to "topaz" in include guards, GN files, etc. |
chinmaygarde
force-pushed
the
fdk_land_flutter_runner
branch
from
May 7, 2019 22:35
99b464c to
16835fd
Compare
Build rules and include paths have been updated as necessary. No other functional change.
chinmaygarde
force-pushed
the
fdk_land_flutter_runner
branch
from
May 7, 2019 23:03
16835fd to
f674093
Compare
Contributor
Author
|
I fixed the guards and licenses. The remaining references are in files that need to be updated one the packaging templates are ported. |
cbracken
reviewed
May 8, 2019
cbracken
left a comment
cbracken
left a comment
Contributor
There was a problem hiding this comment.
{RS}LGTM in modulo the fixes.
| main(List<String> args) async { | ||
| if (args.length != 1) { | ||
| print("Usage:\n" | ||
| " fx syslog | dart topaz/runtime/flutter_runner/collect_traces.dart output.txt"); |
| import("//third_party/dart/build/dart/dart_action.gni") | ||
| import("//topaz/runtime/dart/config.gni") | ||
| import("//topaz/runtime/dart/dart_component.gni") | ||
| import("//topaz/runtime/dart/dart_kernel.gni") |
| after startup from a few apps. | ||
|
|
||
| To update this trace. | ||
| - In //topaz/runtime/flutter_runner/engine.cc, change kCompilationTraceDelayInSeconds to a non-zero value. |
Contributor
There was a problem hiding this comment.
Here and below: update path.
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #include "topaz/runtime/flutter_runner/fuchsia_font_manager.h" |
| import("//third_party/dart/utils/compile_platform.gni") | ||
| import("//topaz/runtime/dart/dart_component.gni") | ||
| import("//topaz/runtime/dart/dart_kernel.gni") | ||
| import("//topaz/runtime/flutter_runner/prebuilt_framework.gni") |
| @@ -0,0 +1,164 @@ | |||
| { | |||
| "comment:0": "NOTE: THIS FILE IS GENERATED. DO NOT EDIT.", | |||
| "comment:1": "Instead modify 'topaz/runtime/flutter_runner/kernel/libraries.yaml' and follow the instructions therein.", | |||
Contributor
There was a problem hiding this comment.
Regenerate (and fix the generator if this is hardcoded -- I assume it's not...)
| # | ||
| # python third_party/dart/tools/yaml2json.py \ | ||
| # topaz/runtime/flutter_runner/kernel/libraries.yaml \ | ||
| # topaz/runtime/flutter_runner/kernel/libraries.json |
cbracken
approved these changes
May 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 8, 2019
This was referenced May 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 8, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 8, 2019
flutter-team-archive/engine@149b7b8...0fc6efb git log 149b7b8..0fc6efb --no-merges --oneline 0fc6efb Roll src/third_party/dart a8b6e18b62..8143450941 (11 commits) 93d1c37 Remove absolute path in new Fuchsia SDK based runner target dependency. (flutter-team-archive/engine#8888) 0b406c3 Copy the Flutter Runner from //topaz into the engine. (flutter-team-archive/engine#8886) 2b1f992 new lints (flutter-team-archive/engine#8849) 0c7a3f2 Copy //dart-pkg/zircon|fuchsia from Topaz into the engine. (flutter-team-archive/engine#8884) ba82ea2 Roll src/third_party/skia 056944747072..51e15a69ce5b (8 commits) (flutter-team-archive/engine#8885) d717044 Copy //runtime/dart/utils from Topaz into the engine. (flutter-team-archive/engine#8871) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
…rchive#8886) Build rules and include paths have been updated as necessary. No other functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build rules and include paths have been updated as necessary.
No other functional change.