This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Uncaught exceptions get two stack traces#718
Merged
Merged
Conversation
Now we print Dart_GetError only when we don't have a stack trace. Also, improve
the usability of the sky_shell command line tool by defaulting to "packages"
for the package-root and not crashing when we don't have a package-root until
we actually try to load a package. Finally, remove console spam when we fail to
bind the observatory port.
Fixes #689
Contributor
|
LGTM but @eseidel might want to look at this too since this isn't my bailiwick. |
abarth
added a commit
that referenced
this pull request
Aug 20, 2015
Uncaught exceptions get two stack traces
Contributor
|
Lgtm
|
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
…traneous_ifdef Remove extraneous ifdef in VkDeviceCreateInfo VU
aam
added a commit
to aam/engine
that referenced
this pull request
Apr 18, 2023
Changes since last roll: ``` 059d155 [dart] Add identifier needed for zlib roll (flutter-team-archive#718) 459d3e5 Bump github/codeql-action from 2.2.11 to 2.2.12 (flutter-team-archive#716) 91f1ba5 Bump actions/checkout from 3.5.1 to 3.5.2 (#715) 2e5c483 Bump actions/checkout from 3.5.0 to 3.5.1 (flutter-team-archive#714) a5af13d Remove codeql. (flutter-team-archive#713) ```
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we print Dart_GetError only when we don't have a stack trace. Also, improve
the usability of the sky_shell command line tool by defaulting to "packages"
for the package-root and not crashing when we don't have a package-root until
we actually try to load a package. Finally, remove console spam when we fail to
bind the observatory port.
Fixes #689