This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove 'Linux mac_clangd' in favor of 'Mac clangd'#56082
Merged
Conversation
zanderso
approved these changes
Oct 24, 2024
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2024
flutter-team-archive/engine@246344f...48ff670 2024-10-24 [email protected] Remove 'Linux mac_clangd' in favor of 'Mac clangd' (flutter-team-archive/engine#56082) 2024-10-24 [email protected] Added thread name to pipeline validation error. (flutter-team-archive/engine#56074) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ive/engine#56082) Follow up to flutter-team-archive/engine#56014 `Mac clangd` is [passing as a standalone build](https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20clangd/60/overview) (<10 minutes). Move it out of bringup and remove `Linux mac_clangd`. flutter#157275 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #56014
Mac clangdis passing as a standalone build (<10 minutes). Move it out of bringup and removeLinux mac_clangd.flutter/flutter#157275
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.