This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
[android] Disable AHB swapchain and import on huawei API 29 devices. - #54879
Merged
auto-submit[bot] merged 4 commits intoAug 30, 2024
Merged
Conversation
matanlurey
approved these changes
Aug 29, 2024
added 2 commits
August 29, 2024 15:28
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2024
flutter-team-archive/engine@dc7eefb...da87db6 2024-08-30 [email protected] [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter-team-archive/engine#54879) 2024-08-29 [email protected] Hooks up framework wide gamut to engine wide gamut (flutter-team-archive/engine#54567) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…4381) flutter-team-archive/engine@dc7eefb...da87db6 2024-08-30 [email protected] [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter-team-archive/engine#54879) 2024-08-29 [email protected] Hooks up framework wide gamut to engine wide gamut (flutter-team-archive/engine#54567) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
1 task done
ghost
mentioned this pull request
|
Hi, Any news on when this will be in Flutter stable channel or if it is already in stable channel can I get the information on which version is it. Thank you. |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From local testing, it seems that AHB imports and swapchain usage of AHBs does not work on these Huawei devices. Vulkan does seem to work OK with these optional features disabled, but so far we've only tested on the P40 Pro.
Fixes flutter/flutter#154068