This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
[engine] add an ios noop context. - #54856
Merged
auto-submit[bot] merged 2 commits intoAug 29, 2024
Merged
Conversation
jonahwilliams
commented
Aug 29, 2024
| "in an environment that does not support Metal. Enabling GPU pass through in your " | ||
| "environment may fix this. If that is not possible, then disable Impeller."; | ||
| if (backend == IOSRenderingBackend::kImpeller) { | ||
| FML_LOG(IMPORTANT) |
Contributor
Author
There was a problem hiding this comment.
I just used the existing warning message, with the part about disablling impeller removed :)
zanderso
approved these changes
Aug 29, 2024
jonahwilliams
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/54856, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2024
flutter-team-archive/engine@f48ecf5...bad9464 2024-08-29 [email protected] [engine] add an ios noop context. (flutter-team-archive/engine#54856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
) flutter-team-archive/engine@f48ecf5...bad9464 2024-08-29 [email protected] [engine] add an ios noop context. (flutter-team-archive/engine#54856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to allow simulators to run without exiting when impeller is enabled and there is no available metal contxt.