This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Remove some trivial forward declares from Impeller - #48635
Merged
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dnfield
changed the title
Contributor
|
test-exempt: code refactor with no semantic change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 4, 2023
flutter-team-archive/engine@c6395d9...de0ba84 2023-12-04 [email protected] Roll Skia from 0fe76d9ce79e to cbd2cf40d63b (1 revision) (flutter-team-archive/engine#48638) 2023-12-04 [email protected] Remove some trivial forward declares from Impeller (flutter-team-archive/engine#48635) 2023-12-04 [email protected] [Windows] Decouple the GL context from the view (flutter-team-archive/engine#48636) 2023-12-04 [email protected] Multiview ExternalViewEmbedder (flutter-team-archive/engine#46169) 2023-12-04 [email protected] Roll Dart SDK from 67f7a2c2559a to a1b67665b3a3 (1 revision) (flutter-team-archive/engine#48637) 2023-12-04 [email protected] Roll Skia from db4a29e0689e to 0fe76d9ce79e (5 revisions) (flutter-team-archive/engine#48634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards flutter/flutter#133417 (comment)
I'll request a test exemption for this as it's a semantics-only refactor.
There are still a bunch of other forward declares in Impeller that make things confusing for tooling, but some of those will require less trivial changes to interfaces.