This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove 'Mac mac_unopt' in favor of Linux#41226
Merged
auto-submit[bot] merged 4 commits intoApr 17, 2023
Merged
Conversation
jmagman
force-pushed
the
remove-mac-unupt
branch
from
April 15, 2023 00:20
14cf0b6 to
0847d83
Compare
jmagman
force-pushed
the
remove-mac-unupt
branch
from
April 15, 2023 01:41
0847d83 to
8410d24
Compare
Contributor
Author
|
|
keyonghan
reviewed
Apr 17, 2023
Comment on lines
+94
to
+98
| "properties": { | ||
| "$flutter/osx_sdk": { | ||
| "sdk_version": "14a5294e" | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
This is already included above.
Comment on lines
+206
to
+210
| "properties": { | ||
| "$flutter/osx_sdk": { | ||
| "sdk_version": "14a5294e" | ||
| } | ||
| }, |
jmagman
marked this pull request as ready for review
April 17, 2023 21:47
Contributor
Author
|
Thanks for the help @keyonghan! |
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2023
flutter-team-archive/engine@20034a8...4a603aa 2023-04-17 [email protected] Remove 'Mac mac_unopt' in favor of Linux (flutter-team-archive/engine#41226) 2023-04-17 [email protected] [Impeller] Add debug ToString methods to render targets. (flutter-team-archive/engine#41221) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux mac_unopt: https://ci.chromium.org/p/flutter/builders/try/Linux%20mac_unopt/4Remove
bringupand removeMac mac_unoptin favor of the Linux orchestrator #41184Add the
xcodeversion to the mac_unopt json file since it's no longer being inherited fromMac mac_unopt.Fixes flutter/flutter#124912