Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) - #38758

Merged
gaaclarke merged 1 commit into
flutter-team-archive:mainfrom
gaaclarke:manual-04bb8c27fbdd95d972a41388ac48f6b880bc2552
Jan 11, 2023
Merged

Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions)#38758
gaaclarke merged 1 commit into
flutter-team-archive:mainfrom
gaaclarke:manual-04bb8c27fbdd95d972a41388ac48f6b880bc2552

Conversation

@gaaclarke

@gaaclarke gaaclarke commented Jan 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Landing this roll manually because it seems to have failed in error and the latest hash has introduced some other errors.
related issue: flutter/flutter#118280

https://skia.googlesource.com/skia.git/+log/b8c0a78a2378..e1f3980272f3

2023-01-09 [email protected] Add support for diagonal matrix contructors in RP codegen. 2023-01-09 [email protected] Reboot Android devices after running a task. 2023-01-09 [email protected] Coalesce adjacent push_zeros ops. 2023-01-09 [email protected] [graphite] More steps to Recording replay for text. 2023-01-09 [email protected] Clean up compilation settings 2023-01-09 [email protected] Clear special surfaces with red color on debug tests 2023-01-09 [email protected] [graphite] Centralize Graphite onMakeTextureImage stubs in SkImage_GpuBase 2023-01-09 [email protected] Add tests for solving cubic roots with double precision. 2023-01-09 [email protected] [graphite] Add onReinterpretColorSpace implementation 2023-01-09 [email protected] Move SkStringView from include/private/base into src/base 2023-01-09 [email protected] jpegr codec: implement opt-in sdr/hdr decoding 2023-01-09 [email protected] Roll SK Tool from 10524e337d18 to 802522fda586 2023-01-09 [email protected] Update SKP version 2023-01-09 [email protected] Roll vulkan-deps from e7c0454c0991 to 8c09d95e66d0 (1 revision) 2023-01-09 [email protected] Roll Skia Infra from 3c706ee3c271 to 10524e337d18 (10 revisions) 2023-01-09 [email protected] Roll ANGLE from 1d2b20f53532 to 9c1598af45f5 (8 revisions) 2023-01-09 [email protected] Roll Dawn from 582ce0b0b4c8 to a3544353e82d (20 revisions) 2023-01-08 49699333+dependabot[bot]@users.noreply.github.com Bump json5 from 1.0.1 to 1.0.2 in /experimental/tskit 2023-01-07 49699333+dependabot[bot]@users.noreply.github.com Bump json5 from 2.1.3 to 2.2.3 in /modules/pathkit 2023-01-07 49699333+dependabot[bot]@users.noreply.github.com Bump json5 from 2.1.3 to 2.2.3 in /modules/canvaskit 2023-01-07 [email protected] Roll vulkan-deps from 68f9998c8591 to e7c0454c0991 (2 revisions) 2023-01-06 [email protected] Roll vulkan-deps from d3d26aeb92d2 to 68f9998c8591 (4 revisions) 2023-01-06 [email protected] Implement x++ and x-- in RP codegen. 2023-01-06 [email protected] Disable fract() intrinsic test on Tegra3.

If this roll has caused a breakage, revert this CL and stop the roller using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@skia-flutter-autoroll @gaaclarke
Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions)
ad333b2 
https://skia.googlesource.com/skia.git/+log/b8c0a78a2378..e1f3980272f3

2023-01-09 [email protected] Add support for diagonal matrix contructors in RP codegen.
2023-01-09 [email protected] Reboot Android devices after running a task.
2023-01-09 [email protected] Coalesce adjacent push_zeros ops.
2023-01-09 [email protected] [graphite] More steps to Recording replay for text.
2023-01-09 [email protected] Clean up compilation settings
2023-01-09 [email protected] Clear special surfaces with red color on debug tests
2023-01-09 [email protected] [graphite] Centralize Graphite onMakeTextureImage stubs in SkImage_GpuBase
2023-01-09 [email protected] Add tests for solving cubic roots with double precision.
2023-01-09 [email protected] [graphite] Add onReinterpretColorSpace implementation
2023-01-09 [email protected] Move SkStringView from include/private/base into src/base
2023-01-09 [email protected] jpegr codec: implement opt-in sdr/hdr decoding
2023-01-09 [email protected] Roll SK Tool from 10524e337d18 to 802522fda586
2023-01-09 [email protected] Update SKP version
2023-01-09 [email protected] Roll vulkan-deps from e7c0454c0991 to 8c09d95e66d0 (1 revision)
2023-01-09 [email protected] Roll Skia Infra from 3c706ee3c271 to 10524e337d18 (10 revisions)
2023-01-09 [email protected] Roll ANGLE from 1d2b20f53532 to 9c1598af45f5 (8 revisions)
2023-01-09 [email protected] Roll Dawn from 582ce0b0b4c8 to a3544353e82d (20 revisions)
2023-01-08 49699333+dependabot[bot]@users.noreply.github.com Bump json5 from 1.0.1 to 1.0.2 in /experimental/tskit
2023-01-07 49699333+dependabot[bot]@users.noreply.github.com Bump json5 from 2.1.3 to 2.2.3 in /modules/pathkit
2023-01-07 49699333+dependabot[bot]@users.noreply.github.com Bump json5 from 2.1.3 to 2.2.3 in /modules/canvaskit
2023-01-07 [email protected] Roll vulkan-deps from 68f9998c8591 to e7c0454c0991 (2 revisions)
2023-01-06 [email protected] Roll vulkan-deps from d3d26aeb92d2 to 68f9998c8591 (4 revisions)
2023-01-06 [email protected] Implement x++ and x-- in RP codegen.
2023-01-06 [email protected] Disable fract() intrinsic test on Tegra3.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gaaclarke
gaaclarke requested a review from flar January 11, 2023 00:39
jonahwilliams
jonahwilliams approved these changes Jan 11, 2023
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke
gaaclarke merged commit 53bd4bb into flutter-team-archive:main Jan 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2023
@engine-flutter-autoroll
53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (f…
e2c9502 
…lutter-team-archive/engine#38758)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 11, 2023
@engine-flutter-autoroll
Roll Flutter Engine from ae9e181 to 53bd4bb (3 revisions) (#118289)
55e3894 
* b9a7234 [web] retain GL/Gr context on window resize (flutter-team-archive/engine#38576)

* fd43606 Add SpringAnimation.js from React Native (flutter-team-archive/engine#38750)

* 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter-team-archive/engine#38758)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from ae9e181 to 53bd4bb (3 revisions) (flutter#11…
2907aab 
…8289)

* b9a7234 [web] retain GL/Gr context on window resize (flutter-team-archive/engine#38576)

* fd43606 Add SpringAnimation.js from React Native (flutter-team-archive/engine#38750)

* 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter-team-archive/engine#38758)
esouthren added a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449)
8c2fdb8 
* init scaled changes

* add correct padding values for M3

* revert unneeded change

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* comment fixes

* test update

* docstring fixes

* e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter-team-archive/engine#38558) (#117779)

* Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781)

* 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter-team-archive/plugins#6889)

* 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter-team-archive/plugins#6886)

* 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter-team-archive/engine#38560) (#117783)

*