Repository navigation
Add SpringAnimation.js from React Native - #38750
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The parts I didn't write are LGTM. |
|
test-exempt: this code as written does not execute yet. tests will come in a later PR. |
Hixie
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 38750, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/engine, pr: 38750, due to Validations Fail. |
| @@ -0,0 +1,5 @@ | |||
| # spring_animation | |||
There was a problem hiding this comment.
It's going to look like this dependency is unused. Should the README contain a warning against removing it?
There was a problem hiding this comment.
We'll be using it shortly.
* b9a7234 [web] retain GL/Gr context on window resize (flutter-team-archive/engine#38576) * fd43606 Add SpringAnimation.js from React Native (flutter-team-archive/engine#38750) * 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter-team-archive/engine#38758)
…8289) * b9a7234 [web] retain GL/Gr context on window resize (flutter-team-archive/engine#38576) * fd43606 Add SpringAnimation.js from React Native (flutter-team-archive/engine#38750) * 53bd4bb Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter-team-archive/engine#38758)
Adding React Native spring animation code and license (as is).
Part 1 of 2 per #37604 (comment)
Issue: flutter/flutter#105687 (comment)
See also: #38733
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.