Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add CI builder for windows-arm64. - #38739

Merged
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
p-b-o:artifacts_arm64
Jan 11, 2023
Merged

Add CI builder for windows-arm64.#38739
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
p-b-o:artifacts_arm64

Conversation

@p-b-o

@p-b-o p-b-o commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

  • Generate zip archives for Windows following target platform.

  • Add CI builder for windows-arm64.

All packages can be cross compiled from an x64 machine. Unittests are disabled, as they require an arm64 machine.

  • Add windows-arm64 to CI.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@p-b-o Pierrick Bouvier
Add CI builder for windows-arm64. (#38394)
893f98e 
* Generate zip archives for Windows following target platform.

* Add CI builder for windows-arm64.

All packages can be cross compiled from an x64 machine.
Unittests are disabled, as they require an arm64 machine.

* Add windows-arm64 to CI.
@flutter-dashboard flutter-dashboard Bot added embedder Related to the embedder API platform-web Code specifically for the web engine platform-windows labels Jan 10, 2023
@p-b-o

p-b-o commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

@loic-sharma @godofredoc Fix mac issue by adding if is_win special case. Ultimately, as the comment suggests, web-sdk artifacts will be unified for all arch, so I guess it's acceptable to do this temporarily.

@p-b-o p-b-o mentioned this pull request Jan 10, 2023
Merged
7 of 8 tasks
@p-b-o p-b-o changed the title Add CI builder for windows-arm64. (#38394) Add CI builder for windows-arm64. Jan 10, 2023
loic-sharma
loic-sharma reviewed Jan 10, 2023
View reviewed changes
Comment thread web_sdk/BUILD.gn
if (target_os == "wasm") {
output = "flutter-web-sdk.zip"
} else if (is_win) {
output = "flutter-web-sdk-${full_target_platform_name}.zip"

@loic-sharma loic-sharma Jan 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @eyebrowsoffire, needed because of this: #38394 (comment)

@eyebrowsoffire eyebrowsoffire Jan 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh, at some point I'd really like to make it so that we just produce a single flutter-web-sdk.zip artifact to the dart infra bucket and make it so that the flutter tool always consumes that artifact, regardless of the host platform (all these flutter-web-sdk-{target}.zip artifacts are actually completely identical anyway). But this is fine for now.

eyebrowsoffire
eyebrowsoffire approved these changes Jan 10, 2023
View reviewed changes
Comment thread web_sdk/BUILD.gn
if (target_os == "wasm") {
output = "flutter-web-sdk.zip"
} else if (is_win) {
output = "flutter-web-sdk-${full_target_platform_name}.zip"

@eyebrowsoffire eyebrowsoffire Jan 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh, at some point I'd really like to make it so that we just produce a single flutter-web-sdk.zip artifact to the dart infra bucket and make it so that the flutter tool always consumes that artifact, regardless of the host platform (all these flutter-web-sdk-{target}.zip artifacts are actually completely identical anyway). But this is fine for now.

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 11, 2023
@auto-submit
auto-submit Bot merged commit 4a8d686 into flutter-team-archive:main Jan 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 12, 2023
@engine-flutter-autoroll
4a8d686 Add CI builder for windows-arm64. (flutter#38394) (flutter-te…
021d34f 
…am-archive/engine#38739)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 12, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 764a9e0 to 4a8d686 (2 revisions) (#118357)
b2b4050 
* 7abc5f1 [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter-team-archive/engine#38786)

* 4a8d686 Add CI builder for windows-arm64. (#38394) (flutter-team-archive/engine#38739)
@p-b-o

p-b-o commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Thanks everyone for helping on merging this 👍

From there, what are the next steps to get the artifacts built for every commit and published?
@godofredoc @loic-sharma

@godofredoc

godofredoc commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Yes, I'll update your recipe's change to get the artifacts uploaded to the current location. Thank you for making these changes it will really help us with the upcoming migration.

@p-b-o

p-b-o commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @godofredoc. Could you ping me on that new PR (or cc in a gerrit review if that's somewhere else), so I can follow those changes?

esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 764a9e0 to 4a8d686 (2 revisions) (flutter#11…
385b471 
…8357)

* 7abc5f1 [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter-team-archive/engine#38786)

* 4a8d686 Add CI builder for windows-arm64. (flutter#38394) (flutter-team-archive/engine#38739)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449