Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Mark nodes as kIsLineBreakingObject by default, TODO further distinctions - #38721

Merged
yaakovschectman merged 6 commits into
flutter-team-archive:mainfrom
yaakovschectman:uiatext_linebreak
Jan 10, 2023
Merged

Mark nodes as kIsLineBreakingObject by default, TODO further distinctions#38721
yaakovschectman merged 6 commits into
flutter-team-archive:mainfrom
yaakovschectman:uiatext_linebreak

Conversation

@yaakovschectman

@yaakovschectman yaakovschectman commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

The line breaking attribute is currently unused, but will be needed for UIA text for Windows a11y. To keep all consecutive objects from being merged into one for screen readers, nodes will be marked as line breaking temporarily by default.

Part of flutter/flutter#118184

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yaakovschectman yaakovschectman self-assigned this Jan 9, 2023
@flutter-dashboard

flutter-dashboard Bot commented Jan 9, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

loic-sharma
loic-sharma reviewed Jan 9, 2023
View reviewed changes
Comment thread shell/platform/common/accessibility_bridge.cc Resolved
@loic-sharma

loic-sharma commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

Can this be tested?

@yaakovschectman
yaakovschectman merged commit c4c9702 into flutter-team-archive:main Jan 10, 2023
@yaakovschectman
yaakovschectman deleted the uiatext_linebreak branch January 10, 2023 16:15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
c4c9702 Mark nodes as kIsLineBreakingObject by default, TODO furthe…
cd0f1f9 
…r distinctions (flutter-team-archive/engine#38721)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
c4c9702 Mark nodes as kIsLineBreakingObject by default, TODO furthe…
a5b94d7 
…r distinctions (flutter-team-archive/engine#38721)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
c4c9702 Mark nodes as kIsLineBreakingObject by default, TODO furthe…
cb30e8a 
…r distinctions (flutter-team-archive/engine#38721)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
c4c9702 Mark nodes as kIsLineBreakingObject by default, TODO furthe…
3279439 
…r distinctions (flutter-team-archive/engine#38721)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
c4c9702 Mark nodes as kIsLineBreakingObject by default, TODO furthe…
2721015 
…r distinctions (flutter-team-archive/engine#38721)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (#118274)
cf529ec 
* ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter-team-archive/engine#38740)

* c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter-team-archive/engine#38721)

* f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter-team-archive/engine#38744)

* 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter-team-archive/engine#38746)

* 95c7b1f Make operator == parameter non-nullable (flutter-team-archive/engine#38663)

* c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter-team-archive/engine#38168)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (flutter#11…
d54feea 
…8274)

* ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter-team-archive/engine#38740)

* c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter-team-archive/engine#38721)

* f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter-team-archive/engine#38744)

* 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter-team-archive/engine#38746)

* 95c7b1f Make operator == parameter non-nullable (flutter-team-archive/engine#38663)

* c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter-team-archive/engine#38168)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449