Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove strict equality check for SkMatrix comparison - #38665

Merged
auto-submit[bot] merged 2 commits into
flutter-team-archive:mainfrom
lin-erik:fix-f10
Jan 5, 2023
Merged

Remove strict equality check for SkMatrix comparison#38665
auto-submit[bot] merged 2 commits into
flutter-team-archive:mainfrom
lin-erik:fix-f10

Conversation

@lin-erik

@lin-erik lin-erik commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Fixes b/262417298

@lin-erik
lin-erik requested a review from akbiggs January 5, 2023 18:33
@flutter-dashboard

flutter-dashboard Bot commented Jan 5, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

akbiggs
akbiggs reviewed Jan 5, 2023
View reviewed changes
Comment thread shell/platform/fuchsia/flutter/gfx_external_view_embedder.cc Resolved
Comment thread shell/platform/fuchsia/flutter/gfx_external_view_embedder.cc Resolved
Comment thread shell/platform/fuchsia/flutter/gfx_external_view_embedder.cc Resolved
@akbiggs akbiggs added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 5, 2023
@auto-submit
auto-submit Bot merged commit a4775c7 into flutter-team-archive:main Jan 5, 2023
lin-erik added a commit to lin-erik/engine that referenced this pull request Jan 6, 2023
@lin-erik
Remove strict equality check for SkMatrix comparison (flutter-team-ar…
a7732de 
…chive#38665)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll
a4775c7 Remove strict equality check for SkMatrix comparison (flutter…
9efc399 
…-team-archive/engine#38665)
lin-erik added a commit that referenced this pull request Jan 9, 2023
@lin-erik
Remove strict equality check for SkMatrix comparison (#38665)
8104913 
Cherrypick:
* Remove strict equality check for SkMatrix comparison (#38665)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 9, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 33d7f8a to 03609b4 (6 revisions) (#118125)
6c225dd 
* c582547 SkBudgeted -> skgpu::Budgeted (flutter-team-archive/engine#38660)

* 3d9214a Bump actions/checkout from 3.1.0 to 3.2.0 (flutter-team-archive/engine#38390)

* a4775c7 Remove strict equality check for SkMatrix comparison (flutter-team-archive/engine#38665)

* 046012e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter-team-archive/engine#38683)

* cda410c Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter-team-archive/engine#38668)

* 03609b4 [web] Fix canvas2d leaks in text measurement (flutter-team-archive/engine#38640)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 33d7f8a to 03609b4 (6 revisions) (flutter#11…
cf5dec7 
…8125)

* c582547 SkBudgeted -> skgpu::Budgeted (flutter-team-archive/engine#38660)

* 3d9214a Bump actions/checkout from 3.1.0 to 3.2.0 (flutter-team-archive/engine#38390)

* a4775c7 Remove strict equality check for SkMatrix comparison (flutter-team-archive/engine#38665)

* 046012e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter-team-archive/engine#38683)

* cda410c Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter-team-archive/engine#38668)

* 03609b4 [web] Fix canvas2d leaks in text measurement (flutter-team-archive/engine#38640)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449)
8c2fdb8 
* init scaled changes

* add correct padding values for M3

* revert unneeded change

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* comment fixes

* test update

* docstring fixes

* e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter-team-archive/engine#38558) (#117779)

* Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781)

* 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter-team-archive/plugins#6889)

* 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter-team-archive/plugins#6886)

* 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter-team-archive/engine#38560) (#117783)

* 3460f34 [fuchsia] Set presentation interval (flutter-team-archive/engine#38549) (#117785)

* Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (#117788)

* 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter-team-archive/engine#38561)

* 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter-team-archive/engine#38563)

* a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter-team-archive/engine#38565) (#117790)

* Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (#117795)

* e012dc8 [Windows] Add engine builder to simplify tests (flutter-team-archive/engine#38546)

* 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (