Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make operator == parameter non-nullable - #38663

Merged
srawlins merged 2 commits into
flutter-team-archive:mainfrom
srawlins:nullable-equal-equal
Jan 10, 2023
Merged

Make operator == parameter non-nullable#38663
srawlins merged 2 commits into
flutter-team-archive:mainfrom
srawlins:nullable-equal-equal

Conversation

@srawlins

@srawlins srawlins commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Make operator == override parameters no-nullable.

Fixes flutter/flutter#117838

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the platform-web Code specifically for the web engine label Jan 5, 2023
@flutter-dashboard

flutter-dashboard Bot commented Jan 5, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@srawlins

srawlins commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

Ready to roll

@srawlins
srawlins merged commit 95c7b1f into flutter-team-archive:main Jan 10, 2023
@srawlins
srawlins deleted the nullable-equal-equal branch January 10, 2023 20:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
95c7b1f Make operator == parameter non-nullable (flutter-team-archive…
9deb8af 
…/engine#38663)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 10, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (#118274)
cf529ec 
* ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter-team-archive/engine#38740)

* c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter-team-archive/engine#38721)

* f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter-team-archive/engine#38744)

* 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter-team-archive/engine#38746)

* 95c7b1f Make operator == parameter non-nullable (flutter-team-archive/engine#38663)

* c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter-team-archive/engine#38168)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 687e3cb to c1d61cf (6 revisions) (flutter#11…
d54feea 
…8274)

* ad9052a Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter-team-archive/engine#38740)

* c4c9702 Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter-team-archive/engine#38721)

* f40af3e Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter-team-archive/engine#38744)

* 41cfbdd Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter-team-archive/engine#38746)

* 95c7b1f Make operator == parameter non-nullable (flutter-team-archive/engine#38663)

* c1d61cf Move canvaskit artifacts to expected location in Web SDK Archive (flutter-team-archive/engine#38168)
esouthren added a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449)
8c2fdb8 
* init scaled changes

* add correct padding values for M3

* revert unneeded change

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* comment fixes

* test update

* docstring fixes

* e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter-team-archive/engine#38558) (#117779)

* Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781)

* 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter-team-archive/plugins#6889)

* 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter-team-archive/plugins#6886)

* 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter-team-archive/engine#38560) (#117783)

* 3460f34 [fuchsia] Set presentation interval (flutter-team-archive/engine#38549) (#117785)

* Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (#117788)

* 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter-team-archive/engine#38561)

* 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter-team-archive/engine#38563)

* a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter-team-archive/engine#38565) (#117790)

* Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (#117795)

* e012dc8 [Windows] Add engine builder to simplify tests (flutter-team-archive/engine#38546)

* 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (flutter-team-archive/engine#38562)

* Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797)

* fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter-team-archive/engine#38554)

* 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter-team-archive/engine#38568)

* 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter-team-archive/engine#38569) (#117799)

* 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter-team-archive/engine#38571) (#117800)

* e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter-team-archive/engine#38572) (#117802)

* af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter-team-archive/engine#38574) (#117804)

* 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter-team-archive/engine#38575) (#117805)

* d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter-team-archive/engine#38578) (#117817)

* b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter-team-archive/plugins#6892) (#117824)

* Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (#117830)

* 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter-team-archive/engine#38579)

* 9153966 [fuchsia] Bump the target API level to 11 (flutter-team-archive/engine#38544)

* b9bf51d Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter-team-archive/engine#38580) (#117832)

* Roll Flutter Engine from b9bf51d to f6ad9b6 (2 revisions) (#117834)

* 4b38736 [Impeller Scene] Import materials, load embedded textures (flutter-team-archive/engine#38577)

* f6ad9b6 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter-team-archive/engine#38581)

* 932591e Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter-team-archive/engine#38584) (#117840)

* 3d8c5ef Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter-team-archive/engine#38585) (#117846)

* Roll Flutter Engine from 3d8c5ef to a7decc3 (2 revisions) (#117856)

* 3470fa8 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter-team-archive/engine#38586)

* a7decc3 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter-team-archive/engine#38587)

* 0a2029c Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter-team-archive/engine#38588) (#117858)

* 5fe7d5b Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter-team-archive/engine#38591) (#117863)

* e5d605b Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter-team-archive/engine#38592) (#117865)

* 71c5f17 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (