Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add TextProvider and TextEdit patterns to AXPlatformNodeWin - #38646

Merged
yaakovschectman merged 2 commits into
flutter-team-archive:mainfrom
yaakovschectman:uiatext_pattern
Jan 5, 2023
Merged

Add TextProvider and TextEdit patterns to AXPlatformNodeWin#38646
yaakovschectman merged 2 commits into
flutter-team-archive:mainfrom
yaakovschectman:uiatext_pattern

Conversation

@yaakovschectman

@yaakovschectman yaakovschectman commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

For UIA implementation, this will enable AXPlatformNodeWin to provide the appropriate text patterns, which will be necessary for more complicated screen reader interop such as narrating the selection.

Part of flutter/flutter#116219

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yaakovschectman yaakovschectman self-assigned this Jan 4, 2023
@yaakovschectman
yaakovschectman marked this pull request as ready for review January 4, 2023 22:21
a-wallen
a-wallen approved these changes Jan 4, 2023
View reviewed changes

@a-wallen a-wallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaakovschectman
yaakovschectman merged commit 072a9ca into flutter-team-archive:main Jan 5, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 5, 2023
@engine-flutter-autoroll
072a9ca Add TextProvider and TextEdit patterns to `AXPlatformNode…
6600fc4 
…Win` (flutter-team-archive/engine#38646)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 5, 2023
@engine-flutter-autoroll
072a9ca Add TextProvider and TextEdit patterns to `AXPlatformNode…
43b9120 
…Win` (flutter-team-archive/engine#38646) (#118039)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Jan 5, 2023
engine-flutter-autoroll sourcegraph-bot
flutter: 072a9ca37 Add TextProvider and TextEdit patterns to `AXP…
2f2e27c 
…latformNodeWin` (flutter-team-archive/engine#38646) (#118039)

Commit: 43b912090224614885a297f8d189ad648b6d7258
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 5, 2023
@engine-flutter-autoroll
43b9120 072a9ca37 Add TextProvider and TextEdit patterns to `AXPl…
9e4a9ce 
…atformNodeWin` (flutter-team-archive/engine#38646) (flutter/flutter#118039)
auto-submit Bot pushed a commit to flutter-team-archive/plugins that referenced this pull request Jan 5, 2023
@engine-flutter-autoroll
Roll Flutter from 231855f to 43b9120 (11 revisions) (#6918)
3a6f63b 
* 672fe20 [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter/flutter#117939)

* fe1271f roll packages (flutter/flutter#117940)

* 341ae18 roll packages (flutter/flutter#118001)

* 873cf51 [Android] Increase timeout duration for spell check integration test (flutter/flutter#117989)

* e2f390a Roll Flutter Engine from 32c468507b32 to cdd3bf29e27a (8 revisions) (flutter/flutter#118014)

* fbb743d 60515762e [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter-team-archive/engine#38628) (flutter/flutter#118016)

* da1a854 35b7dee32 [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter-team-archive/engine#38497) (flutter/flutter#118017)

* a562fe2 b9b0193ea Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter-team-archive/engine#38654) (flutter/flutter#118018)

* 4588606 a01548f5f [Impeller Scene] Fix material/vertex color overlapping (flutter-team-archive/engine#38653) (flutter/flutter#118027)

* 7a5ae7c Roll Plugins from f9dda6a to 3204619 (2 revisions) (flutter/flutter#118040)

* 43b9120 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter-team-archive/engine#38646) (flutter/flutter#118039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll
43b9120 072a9ca37 Add TextProvider and TextEdit patterns to `AXPl…
04d4527 
…atformNodeWin` (flutter-team-archive/engine#38646) (flutter/flutter#118039)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll
Roll Flutter from 4588606 to 5070620 (11 revisions) (#3028)
e1ab965 
* 7a5ae7c Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter/flutter#118040)

* 43b9120 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter-team-archive/engine#38646) (flutter/flutter#118039)

* 5a87a82 bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter-team-archive/engine#38659) (flutter/flutter#118042)

* 0a2e0a4 Avoid using `TextAffinity` in `TextBoundary` (flutter/flutter#117446)

* 36a1caf 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter-team-archive/engine#38393) (flutter/flutter#118048)

* 9b864b8 5bd90d6e7 Consider more roles as text (flutter-team-archive/engine#38645) (flutter/flutter#118049)

* 70d5834 [EMPTY] Commit to refresh the tree that is currently red (flutter/flutter#118062)

* 4f3ed80 Remove doc reference to the deprecated ui.FlutterWindow API (flutter/flutter#118064)

* de2a424 Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter/flutter#116687)

* 57dc071 Adding 'is' to list of kotlin reserved keywords (flutter/flutter#116299)

* 5070620 Added expandIconColor property on ExpansionPanelList Widget (flutter/flutter#115950)
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll @loic-sharma
072a9ca Add TextProvider and TextEdit patterns to `AXPlatformNode…
3eed36b 
…Win` (flutter-team-archive/engine#38646) (flutter#118039)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
072a9ca Add TextProvider and TextEdit patterns to `AXPlatformNode…
3c644e0 
…Win` (flutter-team-archive/engine#38646) (flutter#118039)
esouthren added a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449