Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[flutter roll] quick fix to import map - #38635

Merged
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
XilaiZhang:xilaizhang-map-1
Jan 4, 2023
Merged

auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
XilaiZhang:xilaizhang-map-1

Conversation

@XilaiZhang

@XilaiZhang XilaiZhang commented Jan 4, 2023 •

Copy link
Copy Markdown
Contributor

@XilaiZhang XilaiZhang changed the title fix roll [flutter roll] quick fix to import map Jan 4, 2023
@XilaiZhang
XilaiZhang requested review from bdero and zanderso January 4, 2023 17:45

@zanderso zanderso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me if the presubmits are green. Is this the only instance that needs to be updated?

@XilaiZhang

Copy link
Copy Markdown
Contributor Author

This looks right to me if the presubmits are green. Is this the only instance that needs to be updated?

Thanks for the quick review! Yeah animation_player.h is the only place

@bdero bdero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 4, 2023
@auto-submit
auto-submit Bot merged commit 67440cc into flutter-team-archive:main Jan 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 5, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 5, 2023
* 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter-team-archive/engine#38626)

* c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter-team-archive/engine#38630)

* 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter-team-archive/engine#38631)

* ebf01dc Update FlutterPlatformNodeDelegate (flutter-team-archive/engine#38615)

* d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter-team-archive/engine#38633)

* 67440cc fix roll (flutter-team-archive/engine#38635)

* 87bdde8 Fix build using VS 17.4's C++ STL (flutter-team-archive/engine#38614)

* cdd3bf2 make DisplayListFlags constexpr throughout (flutter-team-archive/engine#38649)
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
…8014)

* 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter-team-archive/engine#38626)

* c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter-team-archive/engine#38630)

* 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter-team-archive/engine#38631)

* ebf01dc Update FlutterPlatformNodeDelegate (flutter-team-archive/engine#38615)

* d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter-team-archive/engine#38633)

* 67440cc fix roll (flutter-team-archive/engine#38635)

* 87bdde8 Fix build using VS 17.4's C++ STL (flutter-team-archive/engine#38614)

* cdd3bf2 make DisplayListFlags constexpr throughout (flutter-team-archive/engine#38649)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
…8014)

* 22f872d Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter-team-archive/engine#38626)

* c5e0f9e Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter-team-archive/engine#38630)

* 398f5d3 Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter-team-archive/engine#38631)

* ebf01dc Update FlutterPlatformNodeDelegate (flutter-team-archive/engine#38615)

* d7dbe5b Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter-team-archive/engine#38633)

* 67440cc fix roll (flutter-team-archive/engine#38635)

* 87bdde8 Fix build using VS 17.4's C++ STL (flutter-team-archive/engine#38614)

* cdd3bf2 make DisplayListFlags constexpr throughout (flutter-team-archive/engine#38649)