Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll quiver to 3.2.1 - #38617

Merged
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
jason-simmons:roll_quiver_010323
Jan 4, 2023
Merged

auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
jason-simmons:roll_quiver_010323

Conversation

@jason-simmons

Copy link
Copy Markdown
Contributor

Need to roll quiver to a version that doesn't depend on BidirectionalIterator, which is being removed in https://dart-review.googlesource.com/c/sdk/+/276741?tab=checks.

@jason-simmons
jason-simmons requested a review from zanderso January 3, 2023 23:10
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jason-simmons

jason-simmons commented Jan 3, 2023 •

Copy link
Copy Markdown
Contributor Author

Based on #38609

@mit-mit

@jason-simmons
jason-simmons force-pushed the roll_quiver_010323 branch 2 times, most recently from 019e42b to 8817910 Compare January 4, 2023 00:48
Need to roll quiver to a version that doesn't depend on BidirectionalIterator, which is being removed in https://dart-review.googlesource.com/c/sdk/+/276741?tab=checks.
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 4, 2023
@auto-submit
auto-submit Bot merged commit 32c4685 into flutter-team-archive:main Jan 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 4, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 4, 2023
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Jan 4, 2023
…38617) (#117942)

Commit: e599e5c9a973249c2b8af96b8958726f2e2b94f2
@mit-mit

mit-mit commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

Thanks!

@mit-mit mit-mit mentioned this pull request Jan 4, 2023
8 tasks done
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 4, 2023
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 4, 2023
* 64e7336 Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter/flutter#117875)

* fe8dcf6 [flutter_tools] timeline_test.dart flaky (flutter/flutter#116667)

* f190559 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter-team-archive/engine#38596) (flutter/flutter#117874)

* ccfd14b Updated to tokens v0.150. (flutter/flutter#117350)

* b9ead37 Simplify null check. (flutter/flutter#117026)

* 084be5e Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter/flutter#117923)

* fdc25a1 Reland "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117916)

* 6b9f1c2 Minor documentation fix on BorderRadiusDirectional.zero (flutter/flutter#117661)

* 889e35b fix typos (flutter/flutter#117592)

* bd69ef7 c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter-team-archive/engine#38610) (flutter/flutter#117931)

* a7942e8 Add convenience constructors for SliverList (flutter/flutter#116605)

* dbd36fb 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter-team-archive/engine#38606) (flutter/flutter#117935)

* 9080d1a Reland "Add support for double tap and drag for text selection #109573" (flutter/flutter#117502)

* 63653e8 == override parameters are non-nullable (flutter/flutter#117839)

* 906761c Fix the message strings for xcodeMissing and xcodeIncomplete (flutter/flutter#117922)

* e599e5c 32c468507 Roll quiver to 3.2.1 (flutter-team-archive/engine#38617) (flutter/flutter#117942)

* c53501d Send text direction in selection rects (flutter/flutter#117436)

* 025ce11 Correctly propagate verbosity to subtasks in flutter.gradle (flutter/flutter#117897)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 4, 2023
auto-submit Bot pushed a commit to flutter-team-archive/plugins that referenced this pull request Jan 4, 2023
* 64e7336 Roll Plugins from b202b3d to e85f8ac (3 revisions) (flutter/flutter#117875)

* fe8dcf6 [flutter_tools] timeline_test.dart flaky (flutter/flutter#116667)

* f190559 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter-team-archive/engine#38596) (flutter/flutter#117874)

* ccfd14b Updated to tokens v0.150. (flutter/flutter#117350)

* b9ead37 Simplify null check. (flutter/flutter#117026)

* 084be5e Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter/flutter#117923)

* fdc25a1 Reland "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117916)

* 6b9f1c2 Minor documentation fix on BorderRadiusDirectional.zero (flutter/flutter#117661)

* 889e35b fix typos (flutter/flutter#117592)

* bd69ef7 c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter-team-archive/engine#38610) (flutter/flutter#117931)

* a7942e8 Add convenience constructors for SliverList (flutter/flutter#116605)

* dbd36fb 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter-team-archive/engine#38606) (flutter/flutter#117935)

* 9080d1a Reland "Add support for double tap and drag for text selection #109573" (flutter/flutter#117502)

* 63653e8 == override parameters are non-nullable (flutter/flutter#117839)

* 906761c Fix the message strings for xcodeMissing and xcodeIncomplete (flutter/flutter#117922)

* e599e5c 32c468507 Roll quiver to 3.2.1 (flutter-team-archive/engine#38617) (flutter/flutter#117942)

* c53501d Send text direction in selection rects (flutter/flutter#117436)

* 025ce11 Correctly propagate verbosity to subtasks in flutter.gradle (flutter/flutter#117897)

* 231855f Roll Plugins from e85f8ac to f9dda6a (3 revisions) (flutter/flutter#117972)
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023