This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Make AccessibilityBridge a AXPlatformTreeManager - #38610
Merged
yaakovschectman merged 5 commits intoJan 3, 2023
Merged
Conversation
yaakovschectman
marked this pull request as ready for review
January 3, 2023 15:40
loic-sharma
reviewed
Jan 3, 2023
| const ui::AXNode::AXID node_id) const { | ||
| auto platform_delegate_weak = GetFlutterPlatformNodeDelegateFromID(node_id); | ||
| if (platform_delegate_weak.expired()) { | ||
| return nullptr; |
Contributor
There was a problem hiding this comment.
Is this case unnecessary due to lock check below? See: https://en.cppreference.com/w/cpp/memory/weak_ptr/lock
loic-sharma
approved these changes
Jan 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 3, 2023
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Jan 3, 2023
…r` (flutter-team-archive/engine#38610) (#117931) Commit: bd69ef70aec5ec7122db107c6dcb48b69018fdcc
This was referenced Jan 4, 2023
Closed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 4, 2023
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 4, 2023
* 64e7336 Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter/flutter#117875) * fe8dcf6 [flutter_tools] timeline_test.dart flaky (flutter/flutter#116667) * f190559 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter-team-archive/engine#38596) (flutter/flutter#117874) * ccfd14b Updated to tokens v0.150. (flutter/flutter#117350) * b9ead37 Simplify null check. (flutter/flutter#117026) * 084be5e Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter/flutter#117923) * fdc25a1 Reland "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117916) * 6b9f1c2 Minor documentation fix on BorderRadiusDirectional.zero (flutter/flutter#117661) * 889e35b fix typos (flutter/flutter#117592) * bd69ef7 c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter-team-archive/engine#38610) (flutter/flutter#117931) * a7942e8 Add convenience constructors for SliverList (flutter/flutter#116605) * dbd36fb 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter-team-archive/engine#38606) (flutter/flutter#117935) * 9080d1a Reland "Add support for double tap and drag for text selection #109573" (flutter/flutter#117502) * 63653e8 == override parameters are non-nullable (flutter/flutter#117839) * 906761c Fix the message strings for xcodeMissing and xcodeIncomplete (flutter/flutter#117922) * e599e5c 32c468507 Roll quiver to 3.2.1 (flutter-team-archive/engine#38617) (flutter/flutter#117942) * c53501d Send text direction in selection rects (flutter/flutter#117436) * 025ce11 Correctly propagate verbosity to subtasks in flutter.gradle (flutter/flutter#117897)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 4, 2023
auto-submit Bot
pushed a commit
to flutter-team-archive/plugins
that referenced
this pull request
Jan 4, 2023
* 64e7336 Roll Plugins from b202b3d to e85f8ac (3 revisions) (flutter/flutter#117875) * fe8dcf6 [flutter_tools] timeline_test.dart flaky (flutter/flutter#116667) * f190559 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter-team-archive/engine#38596) (flutter/flutter#117874) * ccfd14b Updated to tokens v0.150. (flutter/flutter#117350) * b9ead37 Simplify null check. (flutter/flutter#117026) * 084be5e Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter/flutter#117923) * fdc25a1 Reland "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117916) * 6b9f1c2 Minor documentation fix on BorderRadiusDirectional.zero (flutter/flutter#117661) * 889e35b fix typos (flutter/flutter#117592) * bd69ef7 c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter-team-archive/engine#38610) (flutter/flutter#117931) * a7942e8 Add convenience constructors for SliverList (flutter/flutter#116605) * dbd36fb 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter-team-archive/engine#38606) (flutter/flutter#117935) * 9080d1a Reland "Add support for double tap and drag for text selection #109573" (flutter/flutter#117502) * 63653e8 == override parameters are non-nullable (flutter/flutter#117839) * 906761c Fix the message strings for xcodeMissing and xcodeIncomplete (flutter/flutter#117922) * e599e5c 32c468507 Roll quiver to 3.2.1 (flutter-team-archive/engine#38617) (flutter/flutter#117942) * c53501d Send text direction in selection rects (flutter/flutter#117436) * 025ce11 Correctly propagate verbosity to subtasks in flutter.gradle (flutter/flutter#117897) * 231855f Roll Plugins from e85f8ac to f9dda6a (3 revisions) (flutter/flutter#117972)
loic-sharma
pushed a commit
to fluttergithubbot/flutter
that referenced
this pull request
Jan 6, 2023
esouthren
pushed a commit
to esouthren/flutter
that referenced
this pull request
Jan 15, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 16, 2023
For UIA implementation, we must have an
AXPlatformTreeManagerto manage the trees of platform nodes. theAccessibilityBridgealready serves a similar purpose.Part of flutter/flutter#116219
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.