Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Make the engine own the cursor plugin - #38570

Merged
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
loic-sharma:windows_cursor_multiwindow
Jan 3, 2023
Merged

[Windows] Make the engine own the cursor plugin#38570
auto-submit[bot] merged 1 commit into
flutter-team-archive:mainfrom
loic-sharma:windows_cursor_multiwindow

Conversation

@loic-sharma

@loic-sharma loic-sharma commented Dec 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The Windows CursorHandler is a singleton, however, it is owned by the view. This makes the CursorHandler owned by the engine to prepare for a multi-view world.

Part of flutter/flutter#115611

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma
loic-sharma marked this pull request as ready for review December 30, 2022 00:20
yaakovschectman
yaakovschectman approved these changes Jan 3, 2023
View reviewed changes

@yaakovschectman yaakovschectman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2023
@auto-submit
auto-submit Bot merged commit 1d2ba73 into flutter-team-archive:main Jan 3, 2023
loic-sharma added a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@loic-sharma
[Windows] Make the engine own the cursor plugin (flutter-team-archive…
336e188 
…#38570)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 3, 2023
@engine-flutter-autoroll
1d2ba73 [Windows] Make the engine own the cursor plugin (flutter-team…
361f2bb 
…-archive/engine#38570)
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 3, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (#117923)
084be5e 
* 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter-team-archive/engine#38597)

* 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter-team-archive/engine#38598)

* 27960a7 [Impeller Scene] Import animation data (flutter-team-archive/engine#38583)

* b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter-team-archive/engine#38599)

* dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter-team-archive/engine#38601)

* adda2e8 [Impeller Scene] Animation binding and playback (flutter-team-archive/engine#38595)

* 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter-team-archive/engine#38607)

* bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter-team-archive/engine#38538)

* 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter-team-archive/engine#38570)
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll @loic-sharma
Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (flutter#11…
a0805b3 
…7923)

* 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter-team-archive/engine#38597)

* 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter-team-archive/engine#38598)

* 27960a7 [Impeller Scene] Import animation data (flutter-team-archive/engine#38583)

* b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter-team-archive/engine#38599)

* dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter-team-archive/engine#38601)

* adda2e8 [Impeller Scene] Animation binding and playback (flutter-team-archive/engine#38595)

* 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter-team-archive/engine#38607)

* bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter-team-archive/engine#38538)

* 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter-team-archive/engine#38570)
esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 7e51aef to 1d2ba73 (9 revisions) (flutter#11…
46e0d68 
…7923)

* 3e1b0dc Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter-team-archive/engine#38597)

* 8b17efe Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter-team-archive/engine#38598)

* 27960a7 [Impeller Scene] Import animation data (flutter-team-archive/engine#38583)

* b5acb20 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter-team-archive/engine#38599)

* dd0335b Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter-team-archive/engine#38601)

* adda2e8 [Impeller Scene] Animation binding and playback (flutter-team-archive/engine#38595)

* 71a296d Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter-team-archive/engine#38607)

* bde8d45 Implement ITextProvider and ITextRangeProvider for UIA (flutter-team-archive/engine#38538)

* 1d2ba73 [Windows] Make the engine own the cursor plugin (flutter-team-archive/engine#38570)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jan 16, 2023
@esouthren @guidezpl
@engine-flutter-autoroll @Jasguerrero @darrenaustin @asashour @goderbauer @gnprice @CicadaCinema @thkim1011 @Renzo-Olivares Renzo Olivares @srawlins @peixinli @moffatman @mraleph @christopherfujino @fluttergithubbot @camsim99 @LongCatIsLooong @drewroengoogle @jason-simmons @nehalvpatel @gmackall @mackall-work @M97Chahboun @a-wallen a-wallen @morriskurz @LucasXu0 @jmagman @helin24 @TahaTesser @nshahan @yjbanov @bleroux @bdero @loic-sharma Jonah Williams @Time1ess @sigurdm @rydmike @dependabot @isaacscha @andrewkolos @QuncCccccc @joshualitt @awesometic @parlough @IvoB1987 @godofredoc @bernaferrari @IchordeDionysos @HansMuller @vashworth
M3 Button padding adjustments (#118449)
8c2fdb8 
* init scaled changes

* add correct padding values for M3

* revert unneeded change

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* Update packages/flutter/lib/src/material/text_button.dart

Co-authored-by: Pierre-Louis <[email protected]>

* comment fixes

* test update

* docstring fixes

* e44a0de Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter-team-archive/engine#38558) (#117779)

* Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (#117781)

* 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter-team-archive/plugins#6889)

* 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter-team-archive/plugins#6886)

* 4dd8a69 Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter-team-archive/engine#38560) (#117783)

* 3460f34 [fuchsia] Set presentation interval (flutter-team-archive/engine#38549) (#117785)

* Roll Flutter Engine from 3460f34 to 1752b5b (2 revisions) (#117788)

* 332c0a2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter-team-archive/engine#38561)

* 1752b5b Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter-team-archive/engine#38563)

* a63bd85 [fuchsia] Add trace flow for Flatland::Present (flutter-team-archive/engine#38565) (#117790)

* Roll Flutter Engine from a63bd85 to 5713a21 (2 revisions) (#117795)

* e012dc8 [Windows] Add engine builder to simplify tests (flutter-team-archive/engine#38546)

* 5713a21 Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (flutter-team-archive/engine#38562)

* Roll Flutter Engine from 5713a21 to 7800822 (2 revisions) (#117797)

* fd94b04 [Impeller Scene] Import skinned mesh vertex data (flutter-team-archive/engine#38554)

* 7800822 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter-team-archive/engine#38568)

* 9095f7a Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter-team-archive/engine#38569) (#117799)

* 0118b46 Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter-team-archive/engine#38571) (#117800)

* e03d7c8 Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter-team-archive/engine#38572) (#117802)

* af6078b Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter-team-archive/engine#38574) (#117804)

* 7e5cc7b Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter-team-archive/engine#38575) (#117805)

* d4a04a5 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter-team-archive/engine#38578) (#117817)

* b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter-team-archive/plugins#6892) (#117824)

* Roll Flutter Engine from d4a04a5 to 9153966 (2 revisions) (#117830)

* 53806fa Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter-team-archive/engine#38579)

*