Reduce the size of Overlay FlutterImageView in HC mode by Nayuta403 · Pull Request #38393 · flutter-team-archive/engine

Nayuta403 · 2022-12-19T08:53:34Z

In HC mode, for the intersecting layers on top of the Platformview, we create an OverlayImageView display as shown below

But the current size of the Overlay is the size of the Layer, the rectangle where the Layer intersects the Platformview can be calculated to reduce the size of the Overlay. As shown below

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2022-12-19T08:53:37Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Nayuta403 · 2022-12-20T00:00:38Z

@cyanglaz @flar Thanks for the response, you're right.
Sorry, I didn't notice this on ios, but I just noticed it on Android and changed it synchronically. joined_rect.intersect(platform_view_rect) it's a very good deal, I'll do it later.

Hixie · 2022-12-20T00:46:48Z

test-exempt: is tested (for some reason the script didn't detect that?)

flar

LGTM

jmagman · 2022-12-21T21:25:12Z

@cyanglaz can you re-review?

Nayuta403 · 2022-12-22T08:26:49Z

@flar Okay, I added tests

There is something wrong with ci, let me confirm

cyanglaz · 2022-12-22T18:37:12Z

android_external_view_embedder_unittests --repeat=2 this is the failing test command.

You need to run: out/<your_host_build_dir>/android_external_view_embedder_unittests

cyanglaz · 2022-12-23T17:35:37Z

You should find android_external_view_embedder_unittests under out/host_debug_unopt

Nayuta403 · 2022-12-26T02:29:20Z

@cyanglaz Thanks, I finally found it, the tests have been added again, welcome to review

…er-team-archive/engine#38393)

…er-team-archive/engine#38393) (#118048)

…mode (flutter-team-archive/engine#38393) (#118048) Commit: 36a1caf299237330a70e6493df339c95b6682204

…ode (flutter-team-archive/engine#38393) (flutter/flutter#118048)

* 7a5ae7c Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter/flutter#118040) * 43b9120 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter-team-archive/engine#38646) (flutter/flutter#118039) * 5a87a82 bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter-team-archive/engine#38659) (flutter/flutter#118042) * 0a2e0a4 Avoid using `TextAffinity` in `TextBoundary` (flutter/flutter#117446) * 36a1caf 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter-team-archive/engine#38393) (flutter/flutter#118048) * 9b864b8 5bd90d6e7 Consider more roles as text (flutter-team-archive/engine#38645) (flutter/flutter#118049) * 70d5834 [EMPTY] Commit to refresh the tree that is currently red (flutter/flutter#118062) * 4f3ed80 Remove doc reference to the deprecated ui.FlutterWindow API (flutter/flutter#118064) * de2a424 Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter/flutter#116687) * 57dc071 Adding 'is' to list of kotlin reserved keywords (flutter/flutter#116299) * 5070620 Added expandIconColor property on ExpansionPanelList Widget (flutter/flutter#115950)

* 5a87a82 bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter-team-archive/engine#38659) (flutter/flutter#118042) * 0a2e0a4 Avoid using `TextAffinity` in `TextBoundary` (flutter/flutter#117446) * 36a1caf 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter-team-archive/engine#38393) (flutter/flutter#118048) * 9b864b8 5bd90d6e7 Consider more roles as text (flutter-team-archive/engine#38645) (flutter/flutter#118049) * 70d5834 [EMPTY] Commit to refresh the tree that is currently red (flutter/flutter#118062) * 4f3ed80 Remove doc reference to the deprecated ui.FlutterWindow API (flutter/flutter#118064) * de2a424 Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter/flutter#116687) * 57dc071 Adding 'is' to list of kotlin reserved keywords (flutter/flutter#116299) * 5070620 Added expandIconColor property on ExpansionPanelList Widget (flutter/flutter#115950)

…er-team-archive/engine#38393) (flutter#118048)

Nayuta403 added 2 commits December 19, 2022 16:38

intersect

b303bd6

add

08f0127

flutter-dashboard Bot added platform-android platform-ios labels Dec 19, 2022

flutter-dashboard Bot added the needs tests label Dec 19, 2022

Nayuta403 added 2 commits December 19, 2022 18:00

test fix

1adf801

fix test

fc288eb

zanderso requested review from cyanglaz and flar December 19, 2022 16:38

cyanglaz suggested changes Dec 19, 2022

View reviewed changes

Comment thread shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm Resolved

Comment thread shell/platform/android/external_view_embedder/external_view_embedder.cc Resolved

flar suggested changes Dec 19, 2022

View reviewed changes

Comment thread shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm Resolved

Comment thread shell/platform/android/external_view_embedder/external_view_embedder.cc Resolved

Nayuta403 and others added 3 commits December 20, 2022 08:10

modify

dd5b92f

Merge branch 'flutter:main' into overlay

c239b41

typo

79406de

flar suggested changes Dec 20, 2022

View reviewed changes

Comment thread shell/platform/android/external_view_embedder/external_view_embedder.cc Resolved

modify

ebca48f

flar approved these changes Dec 20, 2022

View reviewed changes

flar requested a review from cyanglaz December 20, 2022 09:49

This comment was marked as off-topic.

Sign in to view

test

d876848

Nayuta403 force-pushed the overlay branch from 21433bc to d876848 Compare December 26, 2022 02:23

auto-submit Bot merged commit 74861f3 into flutter-team-archive:main Jan 5, 2023

engine-flutter-autoroll mentioned this pull request Jan 5, 2023

Roll Flutter Engine from bb4015269d3d to 74861f369a9e (1 revision) flutter/flutter#118048

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 5, 2023

74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutt…

17ced35

…er-team-archive/engine#38393)

auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jan 5, 2023

74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutt…

36a1caf

…er-team-archive/engine#38393) (#118048)

sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Jan 5, 2023

flutter: 74861f369 Reduce the size of Overlay FlutterImageView in HC …

74076d0

…mode (flutter-team-archive/engine#38393) (#118048) Commit: 36a1caf299237330a70e6493df339c95b6682204

This was referenced Jan 6, 2023

Roll Flutter from 43b912090224 to 507062032fa4 (9 revisions) flutter-team-archive/plugins#6919

Merged

Roll Flutter from 45886068cf84 to 507062032fa4 (11 revisions) flutter/packages#3028

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 6, 2023

36a1caf 74861f369 Reduce the size of Overlay FlutterImageView in HC m…

25e6ffc

…ode (flutter-team-archive/engine#38393) (flutter/flutter#118048)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2023

36a1caf 74861f369 Reduce the size of Overlay FlutterImageView in HC m…

f59d358

…ode (flutter-team-archive/engine#38393) (flutter/flutter#118048)

loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023

74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutt…

e2486b0

…er-team-archive/engine#38393) (flutter#118048)

esouthren pushed a commit to esouthren/flutter that referenced this pull request Jan 15, 2023

74861f3 Reduce the size of Overlay FlutterImageView in HC mode (flutt…

163c269

…er-team-archive/engine#38393) (flutter#118048)

esouthren added a commit to flutter/flutter that referenced this pull request Jan 16, 2023

Navigation Menu

Repository navigation

Reduce the size of Overlay FlutterImageView in HC mode - #38393

Reduce the size of Overlay FlutterImageView in HC mode#38393
auto-submit[bot] merged 13 commits into
flutter-team-archive:mainfrom
Nayuta403:overlay

Nayuta403 commented Dec 19, 2022 •

edited

Loading

Uh oh!

flutter-dashboard Bot commented Dec 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nayuta403 commented Dec 20, 2022

Uh oh!

Hixie commented Dec 20, 2022

Uh oh!

Uh oh!

flar left a comment

Uh oh!

jmagman commented Dec 21, 2022

Uh oh!

Nayuta403 commented Dec 22, 2022

Uh oh!

This comment was marked as off-topic.

cyanglaz commented Dec 22, 2022 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

cyanglaz commented Dec 23, 2022

Uh oh!

Nayuta403 commented Dec 26, 2022

Uh oh!

Conversation

Nayuta403 commented Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Dec 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nayuta403 commented Dec 20, 2022

Uh oh!

Hixie commented Dec 20, 2022

Uh oh!

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Dec 21, 2022

Uh oh!

Nayuta403 commented Dec 22, 2022

Uh oh!

This comment was marked as off-topic.

cyanglaz commented Dec 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

cyanglaz commented Dec 23, 2022

Uh oh!

Nayuta403 commented Dec 26, 2022

Uh oh!

Nayuta403 commented Dec 19, 2022 •

edited

Loading

cyanglaz commented Dec 22, 2022 •

edited

Loading