This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia][scenic] Add support for viewConnected and viewDisconnected signals in flatland.#36298
Merged
shivesh-ganju merged 1 commit intoSep 20, 2022
Conversation
uysalere
approved these changes
Sep 20, 2022
signals in flatland. This PR adds support for sending 'View.viewConnected' platform message when a view gets created and 'View.viewDisconnected' signal when a view gets destroyed. Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm" Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=93452
shivesh-ganju
force-pushed
the
flatland_new
branch
from
September 20, 2022 21:00
74e8615 to
0d30654
Compare
akbiggs
self-requested a review
September 20, 2022 21:04
shivesh-ganju
added a commit
to shivesh-ganju/engine
that referenced
this pull request
Sep 20, 2022
…lutter-team-archive#36298) signals in flatland. This PR adds support for sending 'View.viewConnected' platform message when a view gets created and 'View.viewDisconnected' signal when a view gets destroyed. Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm" Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=93452
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
…lutter-team-archive#36298) signals in flatland. This PR adds support for sending 'View.viewConnected' platform message when a view gets created and 'View.viewDisconnected' signal when a view gets destroyed. Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm" Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=93452
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for sending 'View.viewConnected' platform message when a view gets created and 'View.viewDisconnected' signal when a view gets destroyed.
Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=93452
Manual Testing
Launched terminal in workstation, checked logs for the newly added platform messages.