This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix inverted setSystemUIChangeCallback#36248
Merged
auto-submit[bot] merged 1 commit intoSep 20, 2022
Merged
Conversation
jiahaog
force-pushed
the
systemchrome-inverted
branch
from
September 20, 2022 00:20
fe716f9 to
65c1f41
Compare
jiahaog
marked this pull request as ready for review
September 20, 2022 01:54
Piinks
approved these changes
Sep 20, 2022
Piinks
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for fixing this - I am still baffled such a clear mix up landed. 🙃
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature of
systemChromeChangedisBut the wrong value of
overlaysAreVisibleis propagated, resulting in the incorrect value received bysetSystemUIChangeCallback.List which issues are fixed by this PR. You must list at least one issue.
Fix flutter/flutter#111618
setSystemUIChangeCallbackisn't used internally, but I also patched this change and ran an internal presubmit to double check. Since there are no failing tests, this isn't a breaking change.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.