Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fxbug.dev/94000: Set Opacity and Scale Flatland Values for Flatland Embedder#36109

Merged
akbiggs merged 199 commits into
flutter-team-archive:mainfrom
cfontas:SetFlatlandValues
Sep 20, 2022
Merged

fxbug.dev/94000: Set Opacity and Scale Flatland Values for Flatland Embedder#36109
akbiggs merged 199 commits into
flutter-team-archive:mainfrom
cfontas:SetFlatlandValues

Conversation

@cfontas

@cfontas cfontas commented Sep 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR makes a few changes to flatland_external_view_embedder as part of fxbug.dev/94000 to enable flatland on smart display.

  • Add Opacity

  • Add Scale

  • Update flatland_external_view_embedder_unittests to verify changes.

Bug: 94000

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboard Bot commented Sep 12, 2022

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cfontas
cfontas requested a review from uysalere September 12, 2022 22:40
@cfontas cfontas changed the title Set Opacity and Update Clipping Comments for Flatland Embedder Set Various Flatland Values for Flatland Embedder (Opacity, Scale, Clipping) Sep 13, 2022
@uysalere
uysalere requested a review from akbiggs September 13, 2022 20:33
@uysalere

uysalere commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Adding @akbiggs as well for reviews.

uysalere
uysalere reviewed Sep 14, 2022
View reviewed changes
Comment thread shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc
Comment thread shell/platform/fuchsia/flutter/tests/fakes/scenic/fake_flatland.cc
@cfontas cfontas changed the title Set Various Flatland Values for Flatland Embedder (Opacity, Scale, Clipping) fxbug.dev/94000: Set Various Flatland Values for Flatland Embedder (Opacity, Scale, Clipping) Sep 14, 2022
@cfontas
cfontas marked this pull request as ready for review September 19, 2022 22:26
@akbiggs
akbiggs merged commit ce9385b into flutter-team-archive:main Sep 20, 2022
@cfontas
cfontas deleted the SetFlatlandValues branch September 20, 2022 22:22
@gaaclarke

gaaclarke commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

This PR has caused the tree to go red and should be reverted. Here is a link to the failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20FEMU/11891/overview

gaaclarke added a commit that referenced this pull request Sep 20, 2022
@gaaclarke
Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Values for Fl…
a0260e2 
…atland Embedder (#36109)"

This reverts commit ce9385b.
This was referenced Sep 20, 2022
Merged
Closed
gaaclarke added a commit that referenced this pull request Sep 20, 2022
@gaaclarke
Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Values for Fl…
d95916d 
…atland Embedder (#36109)" (#36305)

This reverts commit ce9385b.
@gaaclarke gaaclarke mentioned this pull request Sep 20, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
ce9385b fxbug.dev/94000: Set Opacity and Scale Flatland Values for Fl…
c020e3d 
…atland Embedder (flutter-team-archive/engine#36109)
akbiggs added a commit to akbiggs/engine that referenced this pull request Sep 21, 2022
@akbiggs
Revert "Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Value…
5ff7f9f 
…s for Flatland Embedder (flutter-team-archive#36109)" (flutter-team-archive#36305)"

This reverts commit d95916d.

The tryjob failure is not related to this PR. flutter/flutter#112014
@akbiggs akbiggs mentioned this pull request Sep 21, 2022
Merged
akbiggs added a commit that referenced this pull request Sep 21, 2022
@akbiggs
Revert "Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Value…
3a28e8a 
…s for Flatland Embedder (#36109)" (#36305)" (#36323)

This reverts commit d95916d.

The tryjob failure is not related to this PR. flutter/flutter#112014
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@cfontas Oleh
fxbug.dev/94000: Set Opacity and Scale Flatland Values for Flatland E…
8caf556 
…mbedder (flutter-team-archive#36109)

This PR makes a few changes to flatland_external_view_embedder as part of fxbug.dev/94000 to enable flatland on smart display.

- Add Opacity

- Add Scale

= Update flatland_external_view_embedder_unittests to verify changes.

Bug: https://fxbug.dev/94000
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@gaaclarke Oleh
Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Values for Fl…
ddbfaaa 
…atland Embedder (flutter-team-archive#36109)" (flutter-team-archive#36305)

This reverts commit ce9385b.
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@akbiggs Oleh
Revert "Revert "fxbug.dev/94000: Set Opacity and Scale Flatland Value…
c00225a 
…s for Flatland Embedder (flutter-team-archive#36109)" (flutter-team-archive#36305)" (flutter-team-archive#36323)

This reverts commit d95916d.

The tryjob failure is not related to this PR. flutter/flutter#112014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@uysalere uysalere uysalere approved these changes
@akbiggs akbiggs akbiggs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-fuchsia

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.