This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Correct handling for composed character ranges at text.length - #3590
Merged
Merged
Conversation
Contributor
Author
|
Fixes flutter/flutter#9362 Will work with @yjbanov so we can get together driver tests and that provide text editing coverage both iOS and Android. Right now flutter_driver is missing some functionality necessary to deal directly with key events, but for testing IMEs, we're going to need this. |
cbracken
changed the title
Contributor
Author
Fixes a bug wherein a framework side update to the text could trigger a crash. Ensure that both self.text and self.selectedTextRange are updated before triggering textDidChange: or selectionDidChange: on the input delegate (which then re-computes positions). Ensure that rangeOfComposedCharacterSequenceAtIndex: is only ever called for index values > 0 && < self.text.length. This prevents such calls for position with index == self.text.length.
replaceRange:withText: and setMarkedText: are only ever called by UIKit and methods called by UIKit (insertText, deleteBackward), so notification is unnecessary.
chinmaygarde
approved these changes
Apr 13, 2017
This was referenced Apr 13, 2017
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug wherein a framework side update to the text could trigger a
crash.
Ensure that both self.text and self.selectedTextRange are updated before
triggering textDidChange: or selectionDidChange: on the input delegate
(which then re-computes positions). This prevents inconsistencies in
selection vs text position/offset lookups triggered by didChange
notifications.
Ensure that rangeOfComposedCharacterSequenceAtIndex: is only ever called
for index values > 0 && < self.text.length. This prevents such calls for
position with index == self.text.length.
Also reduces unnecessary textDidChange/selectionDidChange notifications:
replaceRange:withText: is only ever called by UIKit and methods called
by UIKit (insertText, deleteBackward), so notification is unnecessary.