This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor - Create Renderer interface for CanvasKit/HTML switching#35502
Merged
auto-submit[bot] merged 18 commits intoAug 23, 2022
Conversation
flutter-dashboard
Bot
added
the
platform-web
yjbanov
reviewed
Aug 18, 2022
mdebbar
approved these changes
Aug 22, 2022
mdebbar
left a comment
mdebbar
left a comment
Contributor
There was a problem hiding this comment.
LGTM! All my comments are nits and minor suggestions.
yjbanov
approved these changes
Aug 23, 2022
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 24, 2022
* 68beed7 Refactor - Create `Renderer` interface for CanvasKit/HTML switching (flutter-team-archive/engine#35502) * 2ecccf1 [Impeller] Enforce a minimum stroke width (flutter-team-archive/engine#35576)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor which creates a
Rendererinterface that is implemented for both CanvasKit and HTML. This will allow us to more easily add and integrate a third renderer.