Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use stricter shadowing warning flags in Flutter targets.#10480

Closed
chinmaygarde wants to merge 1 commit into
flutter-team-archive:masterfrom
chinmaygarde:shadow
Closed

Use stricter shadowing warning flags in Flutter targets.#10480
chinmaygarde wants to merge 1 commit into
flutter-team-archive:masterfrom
chinmaygarde:shadow

Conversation

@chinmaygarde

Copy link
Copy Markdown
Contributor

No description provided.

@chinmaygarde

Copy link
Copy Markdown
Contributor Author

This is related to the comment @stuartmorgan made on another commit about shadowing in lambda captures. I incorrectly stated that this would have been caught with the default shadowing warning flags. This is not true apparently and all shadowing flags are only enabled via the -Wshadow-all flag. We cannot yet enable the same because Skia headers don't fully compile with the stricter warnings. But I will patch them one by one and enable the strictest set of flags. We can also use the current spot to enable Flutter specific warnings in the engine.

@chinmaygarde

Copy link
Copy Markdown
Contributor Author

Ah, I guess I can also use --system-header-prefix. I don't think it is reasonable for stuff in third_party/ to have to adhere to our warning flags.

@chinmaygarde

Copy link
Copy Markdown
Contributor Author

Fails on Fuchsia headers. Will retry again later.

@chinmaygarde chinmaygarde deleted the shadow branch August 9, 2019 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants