Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: de0ba840339c
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f43ef6cbddb0
Choose a head ref
  • 5 commits
  • 32 files changed
  • 3 contributors

Commits on Dec 4, 2023

  1. Add flutter prefix to import (#48617)

    This keeps things consistent with other imports and fixes the internal breakage (b/314687390).
    
    While the build system here is able to handle imports both with and without the `flutter` prefix, the internal mechanism that rewrites these imports is currently unable to handle the latter case.
    jiahaog authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    568a68a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a53ca8a View commit details
    Browse the repository at this point in the history
  3. [Impeller] Move BufferView/Texture/Sampler when binding. (#48628)

    Most of the time we are passing an rvalue into this functions anyway, so in theory moving should be faster. Right?
    Jonah Williams
    Jonah Williams authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    cb133d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. [Impeller] Remove impeller::Path copy constructor. (#48616)

    From looking at profiles, we're always copying paths at least once when recording commands. By deleting the copy constructor, I cna ensure that we're always either moving or explicitly cloning the Path object.
    
    Or, now that I fixed all the moves I could add the copy constructor back.
    Jonah Williams
    Jonah Williams authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    377050b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f43ef6c View commit details
    Browse the repository at this point in the history
Loading