Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c89defa55801
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b6971cdf14f8
Choose a head ref
  • 6 commits
  • 10 files changed
  • 4 contributors

Commits on May 21, 2024

  1. Update file permissions for FlutterMacOS.framework bundle (#52961)

    Fix typo from #52930.  The entire framework bundle/directory needs 755 perms (not recursive), but that PR instead updated the binary within the framework bundle.
    
    Once this rolls I'll rebase flutter/flutter#148786 and merge that test.
    
    Engine-side fix for flutter/flutter#148354
    jmagman authored May 21, 2024
    Configuration menu
    Copy the full SHA
    eaaf1ef View commit details
    Browse the repository at this point in the history
  2. [web] Adds Noto Serif Tibetan fallback font. (#52971)

    This PR adds the "Noto Serif Tibetan" fallback font to Flutter Web, so it can render Dzongkha, and other languages in Tibetan script.
    
    (In order to add this fallback font, an automated script is run which updates the versions and glyphs of other fallback fonts at the same time)
    
    (Bundle uploaded to CIPD)
    
    ## Issues
    
    * Fixes flutter/flutter#148797
    
    ## Testing
    
    * Added unit test for font resolution with sample text
    * Manually, in localhost, using the sample Dzongkha test from the Noto site:
    
    <img width="959" alt="Screenshot 2024-05-21 at 2 01 19�PM" src="https://github.com/flutter/engine/assets/1255594/3f2db34d-c004-4b90-9fda-62a9cff817f9">
    
    ```
    �ེ�ཡ�� འ����ླི������ི��ི���ེ�����ྲ���ྲི�ས� �ེ�ལས��ལ������ུ��ི���ི�འ�ྱ����ོ��ོ��ེ�
    ```
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    ditman authored May 21, 2024
    Configuration menu
    Copy the full SHA
    e310320 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85f4429 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    7b4d58a View commit details
    Browse the repository at this point in the history
  2. [Impeller] Round out subpass coverage. (#52973)

    Resolves flutter/flutter#146967
    
    I added a detailed comment inline explaining why we need this. The visual issues in the reported issue were due to nearest sampling while straddling a half pixel offset.
    
    Before:
    ![image](https://github.com/flutter/engine/assets/919017/ccd89a87-4643-4e4d-9e24-56f28f317e2f)
    
    After:
    <img width="964" alt="image" src="https://github.com/flutter/engine/assets/919017/0be88453-1014-443b-bc80-6df459adb075">
    bdero authored May 22, 2024
    Configuration menu
    Copy the full SHA
    106e719 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6971cd View commit details
    Browse the repository at this point in the history
Loading