Repository navigation
Comparing changes
Open a pull request
base repository: flutter-team-archive/engine
base: c89defa55801
head repository: flutter-team-archive/engine
compare: b6971cdf14f8
- 6 commits
- 10 files changed
- 4 contributors
Commits on May 21, 2024
-
Update file permissions for FlutterMacOS.framework bundle (#52961)
Fix typo from #52930. The entire framework bundle/directory needs 755 perms (not recursive), but that PR instead updated the binary within the framework bundle. Once this rolls I'll rebase flutter/flutter#148786 and merge that test. Engine-side fix for flutter/flutter#148354
Configuration menu - View commit details
-
Copy full SHA for eaaf1ef - Browse repository at this point
Copy the full SHA eaaf1efView commit details -
[web] Adds Noto Serif Tibetan fallback font. (#52971)
This PR adds the "Noto Serif Tibetan" fallback font to Flutter Web, so it can render Dzongkha, and other languages in Tibetan script. (In order to add this fallback font, an automated script is run which updates the versions and glyphs of other fallback fonts at the same time) (Bundle uploaded to CIPD) ## Issues * Fixes flutter/flutter#148797 ## Testing * Added unit test for font resolution with sample text * Manually, in localhost, using the sample Dzongkha test from the Noto site: <img width="959" alt="Screenshot 2024-05-21 at 2 01 19�PM" src="https://github.com/flutter/engine/assets/1255594/3f2db34d-c004-4b90-9fda-62a9cff817f9"> ``` �ེ�ཡ�� འ����ླི������ི��ི���ེ�����ྲ���ྲི�ས� �ེ�ལས��ལ������ུ��ི���ི�འ�ྱ����ོ��ོ��ེ� ``` [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for e310320 - Browse repository at this point
Copy the full SHA e310320View commit details -
Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) (#52972)
https://dart.googlesource.com/sdk.git/+log/f0ac30bbc63e..fca7dd796e81 2024-05-21 [email protected] Version 3.5.0-178.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 85f4429 - Browse repository at this point
Copy the full SHA 85f4429View commit details
Commits on May 22, 2024
-
Roll Skia from 968e971e438e to 78069713e02a (1 revision) (#52974)
https://skia.googlesource.com/skia.git/+log/968e971e438e..78069713e02a 2024-05-21 [email protected] Fix signedness of format string. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 7b4d58a - Browse repository at this point
Copy the full SHA 7b4d58aView commit details -
[Impeller] Round out subpass coverage. (#52973)
Resolves flutter/flutter#146967 I added a detailed comment inline explaining why we need this. The visual issues in the reported issue were due to nearest sampling while straddling a half pixel offset. Before:  After: <img width="964" alt="image" src="https://github.com/flutter/engine/assets/919017/0be88453-1014-443b-bc80-6df459adb075">
Configuration menu - View commit details
-
Copy full SHA for 106e719 - Browse repository at this point
Copy the full SHA 106e719View commit details -
Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz…
…... (#52975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b6971cd - Browse repository at this point
Copy the full SHA b6971cdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c89defa55801...b6971cdf14f8