Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c6395d920786
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: de0ba840339c
Choose a head ref
  • 6 commits
  • 35 files changed
  • 4 contributors

Commits on Dec 4, 2023

  1. Roll Skia from db4a29e0689e to 0fe76d9ce79e (5 revisions) (#48634)

    https://skia.googlesource.com/skia.git/+log/db4a29e0689e..0fe76d9ce79e
    
    2023-12-04 [email protected] [graphite] Enable GMs that no longer fail readback
    2023-12-04 [email protected] Add support for getting a VertexWriter from the UploadManager.
    2023-12-04 [email protected] Add Vulkan subclass of GrContextThreadSafeProxy
    2023-12-04 [email protected] Roll ANGLE from 3fe678c9b297 to fb6b960c0a73 (17 revisions)
    2023-12-04 [email protected] [Graphite] Track CommandBuffer refs for textures instead of Usage on CommandBuffer.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    bfffba9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e22d34f View commit details
    Browse the repository at this point in the history
  3. Multiview ExternalViewEmbedder (#46169)

    This PR adds multiview support for `ExternalViewEmbedder`.
    
    ## Nomenclature
    
    The term **view** can be ambiguous in `ExternalViewEmbedder`, and therefore the following terms are used:
    * A **native view** refers to the final drawing surface that to composite layers to. It is the "view" used in other places of the engine, such as `Shell::AddView`.
    * A **platform view** refers a platform view, a layer that holds content to be embedded.
    
    ## Change
    
    The lifecycle of `ExternalViewEmbedder` is changed:
    
    <table>
        <thead>
            <tr>
                <th>Before PR</th>
                <th>After PR</th>
                <th>How it's called</th>
            </tr>
        </thead>
        <tbody>
            <tr>
                <td rowspan=2>BeginFrame</td>
                <td>BeginFrame</td>
                <td>Once per frame</td>
            </tr>
            <tr>
                <td>PrepareFlutterView</td>
                <td>Once per flutter view</td>
            </tr>
            <tr>
                <td>SubmitFrame</td>
                <td>SubmitFlutterView (renamed)</td>
                <td>Once per flutter view</td>
            </tr>
            <tr>
                <td>EndFrame</td>
                <td>EndFrame (unchanged)</td>
                <td>Once per frame</td>
            </tr>
        </tbody>
    </table>
    
    * `BeginFrame` should perform per-frame actions, such as merge-unmerging threads.
    * `PrepareView` should perform per-native-view preparations, such as recording the view ID and view size.
    
    This change is necessary because some actions in `PrepareView` needs to be refreshed at the beginning of drawing every native view.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    dkwingsmt authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e532e4b View commit details
    Browse the repository at this point in the history
  4. [Windows] Decouple the GL context from the view (#48636)

    In the future, the GL context will be shared between zero or more views. The engine will also need to be able to make the GL context current even if the app is currently in headless mode.
    
    No tests are updated as this is a refactoring with no functionality changes.
    
    Part of flutter/flutter#137267
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    loic-sharma authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    c115ccf View commit details
    Browse the repository at this point in the history
  5. Remove some trivial forward declares from Impeller (#48635)

    Towards flutter/flutter#133417 (comment)
    
    I'll request a test exemption for this as it's a semantics-only refactor.
    
    There are still a bunch of other forward declares in Impeller that make things confusing for tooling, but some of those will require less trivial changes to interfaces.
    dnfield authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    3e93395 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    de0ba84 View commit details
    Browse the repository at this point in the history
Loading