Repository navigation
Comparing changes
Open a pull request
base repository: flutter-team-archive/engine
base: c6395d920786
head repository: flutter-team-archive/engine
compare: de0ba840339c
- 6 commits
- 35 files changed
- 4 contributors
Commits on Dec 4, 2023
-
Roll Skia from db4a29e0689e to 0fe76d9ce79e (5 revisions) (#48634)
https://skia.googlesource.com/skia.git/+log/db4a29e0689e..0fe76d9ce79e 2023-12-04 [email protected] [graphite] Enable GMs that no longer fail readback 2023-12-04 [email protected] Add support for getting a VertexWriter from the UploadManager. 2023-12-04 [email protected] Add Vulkan subclass of GrContextThreadSafeProxy 2023-12-04 [email protected] Roll ANGLE from 3fe678c9b297 to fb6b960c0a73 (17 revisions) 2023-12-04 [email protected] [Graphite] Track CommandBuffer refs for textures instead of Usage on CommandBuffer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for bfffba9 - Browse repository at this point
Copy the full SHA bfffba9View commit details -
Roll Dart SDK from 67f7a2c2559a to a1b67665b3a3 (1 revision) (#48637)
https://dart.googlesource.com/sdk.git/+log/67f7a2c2559a..a1b67665b3a3 2023-12-04 [email protected] Version 3.3.0-189.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for e22d34f - Browse repository at this point
Copy the full SHA e22d34fView commit details -
Multiview ExternalViewEmbedder (#46169)
This PR adds multiview support for `ExternalViewEmbedder`. ## Nomenclature The term **view** can be ambiguous in `ExternalViewEmbedder`, and therefore the following terms are used: * A **native view** refers to the final drawing surface that to composite layers to. It is the "view" used in other places of the engine, such as `Shell::AddView`. * A **platform view** refers a platform view, a layer that holds content to be embedded. ## Change The lifecycle of `ExternalViewEmbedder` is changed: <table> <thead> <tr> <th>Before PR</th> <th>After PR</th> <th>How it's called</th> </tr> </thead> <tbody> <tr> <td rowspan=2>BeginFrame</td> <td>BeginFrame</td> <td>Once per frame</td> </tr> <tr> <td>PrepareFlutterView</td> <td>Once per flutter view</td> </tr> <tr> <td>SubmitFrame</td> <td>SubmitFlutterView (renamed)</td> <td>Once per flutter view</td> </tr> <tr> <td>EndFrame</td> <td>EndFrame (unchanged)</td> <td>Once per frame</td> </tr> </tbody> </table> * `BeginFrame` should perform per-frame actions, such as merge-unmerging threads. * `PrepareView` should perform per-native-view preparations, such as recording the view ID and view size. This change is necessary because some actions in `PrepareView` needs to be refreshed at the beginning of drawing every native view. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#styleConfiguration menu - View commit details
-
Copy full SHA for e532e4b - Browse repository at this point
Copy the full SHA e532e4bView commit details -
[Windows] Decouple the GL context from the view (#48636)
In the future, the GL context will be shared between zero or more views. The engine will also need to be able to make the GL context current even if the app is currently in headless mode. No tests are updated as this is a refactoring with no functionality changes. Part of flutter/flutter#137267 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for c115ccf - Browse repository at this point
Copy the full SHA c115ccfView commit details -
Remove some trivial forward declares from Impeller (#48635)
Towards flutter/flutter#133417 (comment) I'll request a test exemption for this as it's a semantics-only refactor. There are still a bunch of other forward declares in Impeller that make things confusing for tooling, but some of those will require less trivial changes to interfaces.
Configuration menu - View commit details
-
Copy full SHA for 3e93395 - Browse repository at this point
Copy the full SHA 3e93395View commit details -
Roll Skia from 0fe76d9ce79e to cbd2cf40d63b (1 revision) (#48638)
https://skia.googlesource.com/skia.git/+log/0fe76d9ce79e..cbd2cf40d63b 2023-12-04 [email protected] Roll skcms from 4dba2348bc3c to 529510fe003a (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for de0ba84 - Browse repository at this point
Copy the full SHA de0ba84View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c6395d920786...de0ba840339c