Repository navigation
Comparing changes
Open a pull request
base repository: flutter-team-archive/engine
base: 7dfdcacd8ae4
head repository: flutter-team-archive/engine
compare: 38b6165f137d
- 5 commits
- 10 files changed
- 4 contributors
Commits on Nov 1, 2024
-
[impeller] use greater equal rather than greater depth compare. (#56310)
Marking ready for review for golden testing Fixes flutter/flutter#153504 Fixes some other ones too? It seems like metal and vulkan are already behaving like they are using greater equal depth compare. GL behaves correctly like greater compare, but that leads to rendering bugs. Just switch it to greater equal
Jonah Williams authoredNov 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 3565517 - Browse repository at this point
Copy the full SHA 3565517View commit details -
Write run_tests console logs to stdout instead of stderr (#56312)
Users of this script typically expect that the normal output of the tests will be written to stdout. However, the logging.StreamHandler writes to stderr by default unless another stream is specified.
Configuration menu - View commit details
-
Copy full SHA for 71fa584 - Browse repository at this point
Copy the full SHA 71fa584View commit details -
Remove superfluous dart2wasm test suites/bundles. (#56315)
When dart2wasm was still in early stages and unstable, we wanted to run dart2wasm on as many unit tests and code paths as possible. However, dart2wasm is much more stable now, and there are some configurations that users simply cannot not use and are not worth testing. Specifically, users cannot use renderers other than skwasm with dart2wasm, so we should avoid running test suites specific to those renderers. * `dart2wasm-html-html` and `dart2wasm-canvaskit-canvaskit` bundles and their associated suites are removed. These are tests specifically for the `html` and `canvaskit` renderers, which are run with those renderers. Users can't use these renderers in dart2wasm mode, so it's not useful to run these tests. * `dart2wasm-html-ui` and `dart2wasm-canvaskit-ui` and their associated suites are also removed. These are tests that can run on any renderer, and they are being run with the `html` and `canvaskit` renderers. We don't need to run against these renderers on `dart2wasm` since users can't actually use these renderers in dart2wasm mode. * Notably, `dart2wasm-html-engine` and associated suites are staying. These run against the `html` renderer, but only incidentally. These tests are supposed to be exercising logic that doesn't actually pertain to rendering, and it's logic that will be running for the end user in dart2wasm mode. So it makes sense to continue running these tests against dart2wasm.
Configuration menu - View commit details
-
Copy full SHA for 86b7d74 - Browse repository at this point
Copy the full SHA 86b7d74View commit details -
Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (#56320)
https://skia.googlesource.com/skia.git/+log/dfbb0e6bc974..89ac72bb4922 2024-11-01 [email protected] Add job to test rust png codec 2024-11-01 [email protected] [viewer] Initial mesh gradient slide 2024-11-01 [email protected] [Ganesh] Test for valid GL sync before deleting 2024-11-01 [email protected] [pdf] Augment glyph to unicode map 2024-11-01 [email protected] Fix glClientWaitSync and glWaitSync on WebGL2 2024-11-01 [email protected] [Graphite] Unmap vulkan instrinsic buffers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for baffbc6 - Browse repository at this point
Copy the full SHA baffbc6View commit details -
[Impeller] fix downsample with decal tile mode. (#56316)
Fixes flutter/flutter#157956 Fixes flutter/flutter#157959 Decal tile mode needs to be emulated on platforms that don't support it.
Jonah Williams authoredNov 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 38b6165 - Browse repository at this point
Copy the full SHA 38b6165View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7dfdcacd8ae4...38b6165f137d