Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 58ac1dadd69d
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b36ca3319825
Choose a head ref
  • 9 commits
  • 30 files changed
  • 7 contributors

Commits on Nov 6, 2024

  1. Roll Skia from b4df8dda7ffc to afaed8923682 (14 revisions) (#56404)

    https://skia.googlesource.com/skia.git/+log/b4df8dda7ffc..afaed8923682
    
    2024-11-06 [email protected] Ignore more tests in Protected configs
    2024-11-06 [email protected] [graphite] Add UMA enum histogram for Pipeline creation races
    2024-11-06 [email protected] [viewer] Add some hardcoded vertices for mesh gradient sample
    2024-11-06 [email protected] [viewer] Add AE mesh gradient sample
    2024-11-06 [email protected] [infra] Add 'patch' asset
    2024-11-06 [email protected] Adding few missing #ifdefs
    2024-11-06 [email protected] [graphite] Support providing clip on replay
    2024-11-06 [email protected] Roll SwiftShader from 1495532f997f to 76855a9baecc (1 revision)
    2024-11-06 [email protected] Roll Skia Infra from 064137920a75 to 0262f84fa0d7 (6 revisions)
    2024-11-06 [email protected] Proof of concept for general path interpolation
    2024-11-06 [email protected] Temporarily remove golo machines from CQ
    2024-11-06 [email protected] Roll vulkan-deps from 97c315f09386 to e154ea2ed72d (6 revisions)
    2024-11-06 [email protected] Roll ANGLE from 84a24a1ea6a6 to 644b91f7e096 (7 revisions)
    2024-11-06 [email protected] Roll Dawn from 08b478b3f3a3 to a8eb33756b22 (6 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    20ea348 View commit details
    Browse the repository at this point in the history
  2. [Impeller] Avoid errors due to triangle fans usage on Molten. (#56321)

    Added the test case for flutter/flutter#157885 to the corpus but Jonah fixed it in #56310.
    
    Fixes flutter/flutter#158024 which is more of an inconvenience on macOS.
    chinmaygarde authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    78f9dcf View commit details
    Browse the repository at this point in the history
  3. Manual roll Dart SDK from 1c1d0420539f to d456f613465a (6 revisions) (#…

    …56406)
    
    Manual roll requested by [email protected]
    
    https://dart.googlesource.com/sdk.git/+log/1c1d0420539f..d456f613465a
    
    2024-11-06 [email protected] Version 3.7.0-112.0.dev
    2024-11-06 [email protected] Version 3.7.0-111.0.dev
    2024-11-06 [email protected] Version 3.7.0-110.0.dev
    2024-11-06 [email protected] Version 3.7.0-109.0.dev
    2024-11-06 [email protected] Version 3.7.0-108.0.dev
    2024-11-06 [email protected] Version 3.7.0-107.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    454db36 View commit details
    Browse the repository at this point in the history
  4. Roll Skia from afaed8923682 to cf33c4e96e81 (5 revisions) (#56408)

    https://skia.googlesource.com/skia.git/+log/afaed8923682..cf33c4e96e81
    
    2024-11-06 [email protected] Take into account the backdrop filter when calculating the bounds of a SaveLayer operation.
    2024-11-06 [email protected] [viewer] More path interpolation samples
    2024-11-06 [email protected] SkCrabbyAvif: Remove explicit brand sniffing in IsAvif
    2024-11-06 [email protected] SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec
    2024-11-06 [email protected] [graphite] Rename all things ForceSynchronous to ForPrecompile
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4950bb4 View commit details
    Browse the repository at this point in the history
  5. iOS,macOS: Add Obj-C cflags to all Obj-C targets (#56386)

    Ensure that all Objective-C code in the codebase is being built with the standard set of Flutter Objective-C compiler flags with ARC enabled.
    
    Also bumps the cflags config up to the top of the first block within each target in which Objective-C sources appear, so that the location is consistent.
    
    Migrates The following targets to ARC, which had been missed in previous passes since they didn't declare the standard Flutter Obj-C[++] cflags:
    * `//flutter/fml:fml_unittests`
    * `//flutter/impeller/golden_tests:metal_screenshot`
    * `//flutter/impeller/playground:playground`
    * `//flutter/impeller/backend/metal:metal`
    * `//flutter/impeller/backend/metal:metal_unittests`
    * `//shell/gpu:gpu_surface_metal_unittests`
    * `//flutter/shell/platform/embedder:embedder_unittests`
    
    This patch includes no semantic changes.
    
    Issue: flutter/flutter#137801
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3df1546 View commit details
    Browse the repository at this point in the history
  6. Roll ICU from 9408c6fd4a39 to 4239b1559d11 (2 revisions) (#56407)

    Redo #56401 with a manual license change to remove the chromeos/icudtl.dat.hash. The file was removed by https://crrev.com/83a7bd47a345137ac6081c71c2a7158f5403cd30.
    
    Original change description:
    
    https://chromium.googlesource.com/chromium/deps/icu.git/+log/9408c6fd4a39..4239b1559d11
    
    2024-10-02 [[email protected]](mailto:[email protected]) Updated TZ to 2024b
    2024-09-05 [[email protected]](mailto:[email protected]) Remove icudtl.dat.hash
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/icu-sdk-flutter-engine
    Please CC [[email protected]](mailto:[email protected]),[[email protected]](mailto:[email protected]) on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in ICU: https://github.com/unicode-org/icu
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    zijiehe-google-com authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    eec1ba4 View commit details
    Browse the repository at this point in the history
  7. [Impeller] Do not capture the temporary ImpellerMapping struct pointe…

    …r when storing release callbacks in libImpeller (#56411)
    
    Fixes flutter/flutter#158285
    jason-simmons authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    48c10de View commit details
    Browse the repository at this point in the history
  8. [Impeller] generate stroke vertices into point arena. (#56390)

    Heap allocation is extremely expensive on Android.
    
    We can speed up the stroke tessellation by allocation a large arena and using that to write vertices. If the vertices would overflow, we switch to a dynamically allocated vector.
    jonahwilliams authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    00c22da View commit details
    Browse the repository at this point in the history
  9. [skwasm] Fix empty backdrop drawing. (#56385)

    If our operation affects the backdrop, the layer slice builder needs to take that into account when deciding whether to actually build a slice. In addition, we should take the content in the backdrop into account when calculating the cull rect for our picture recorders.
    
    For this to actually work, we need a fix for https://g-issues.skia.org/issues/362552959 which I am currently working on.
    eyebrowsoffire authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b36ca33 View commit details
    Browse the repository at this point in the history
Loading