Vulkan: Don't update pipeline when only textures change.

null77 · Commit Bot · commit dfd760055152 · 2019-06-21T22:54:13.000Z
We could expand this functionality in the future to only update the pipeline when a signficiant bit of pipeline state changes. For now this is mostly a proof of concept. Significantly improves performance in the textures microbenchmark. Bug: angleproject:3117 Change-Id: I3957dd2f08d7d89694f94ddbe45eeeeb620bac0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650790 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
diff --git a/src/libANGLE/renderer/vulkan/ContextVk.cpp b/src/libANGLE/renderer/vulkan/ContextVk.cpp
@@ -222,6 +222,9 @@ ContextVk::ContextVk(const gl::State &state, gl::ErrorSet *errorSet, RendererVk
 
     mDirtyBits = mNewCommandBufferDirtyBits;
     mActiveTextures.fill(nullptr);
+
+    mPipelineDirtyBitsMask.set();
+    mPipelineDirtyBitsMask.reset(gl::State::DIRTY_BIT_TEXTURE_BINDINGS);
 }
 
 #undef INIT
@@ -1390,7 +1393,7 @@ angle::Result ContextVk::syncState(const gl::Context *context,
                                    const gl::State::DirtyBits &dirtyBits,
                                    const gl::State::DirtyBits &bitMask)
 {
-    if (dirtyBits.any())
+    if ((dirtyBits & mPipelineDirtyBitsMask).any())
     {
         invalidateVertexAndIndexBuffers();
     }
diff --git a/src/libANGLE/renderer/vulkan/ContextVk.h b/src/libANGLE/renderer/vulkan/ContextVk.h
@@ -590,6 +590,8 @@ class ContextVk : public ContextImpl, public vk::Context, public vk::CommandBuff
 
     // Generator for texure serials.
     SerialFactory mTextureSerialFactory;
+
+    gl::State::DirtyBits mPipelineDirtyBitsMask;
 };
 }  // namespace rx
 

Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,9 @@ ContextVk::ContextVk(const gl::State &state, gl::ErrorSet *errorSet, RendererVk`
`222`	`222`
`223`	`223`	`mDirtyBits = mNewCommandBufferDirtyBits;`
`224`	`224`	`mActiveTextures.fill(nullptr);`
	`225`	`+`
	`226`	`+ mPipelineDirtyBitsMask.set();`
	`227`	`+ mPipelineDirtyBitsMask.reset(gl::State::DIRTY_BIT_TEXTURE_BINDINGS);`
`225`	`228`	`}`
`226`	`229`
`227`	`230`	`#undef INIT`
`@@ -1390,7 +1393,7 @@ angle::Result ContextVk::syncState(const gl::Context *context,`
`1390`	`1393`	`const gl::State::DirtyBits &dirtyBits,`
`1391`	`1394`	`const gl::State::DirtyBits &bitMask)`
`1392`	`1395`	`{`
`1393`		`- if (dirtyBits.any())`
	`1396`	`+ if ((dirtyBits & mPipelineDirtyBitsMask).any())`
`1394`	`1397`	`{`
`1395`	`1398`	`invalidateVertexAndIndexBuffers();`
`1396`	`1399`	`}`