Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 461f64e

Browse files
authored
Re-enable logging. (#19756)
* Re-enable logging. fuchsia_ctl was updated to support processing the logs as a stream instead of keeping them in the process. Bug: flutter/flutter#57273 * Add path to logs file. * Add the isolated output env directly to the script. * Save log to local directory and printing it using cat. * Try collecting and printing logs as separate steps.
1 parent c783f1b commit 461f64e

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

‎testing/fuchsia/run_tests.sh‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,18 @@ else
3737
fi
3838

3939
reboot() {
40-
# TODO come up with better log collection strategy.
41-
# https://github.com/flutter/flutter/issues/57273
42-
# echo "Dumping system logs..."
43-
44-
# ./fuchsia_ctl -d $device_name ssh \
45-
# -c "log_listener --dump_logs yes" \
46-
# --timeout-seconds $ssh_timeout_seconds \
47-
# --identity-file $pkey
40+
./fuchsia_ctl -d $device_name ssh \
41+
-c "log_listener --dump_logs yes --file /tmp/log.txt" \
42+
--timeout-seconds $ssh_timeout_seconds \
43+
--identity-file $pkey
44+
# As we are not using recipes we don't have a way to know the location
45+
# to upload the log to isolated. We are saving the log to a file to avoid dart
46+
# hanging when running the process and then just using printing the content to
47+
# the console.
48+
./fuchsia_ctl -d $device_name ssh \
49+
-c "cat /tmp/log.txt" \
50+
--timeout-seconds $ssh_timeout_seconds \
51+
--identity-file $pkey
4852

4953
echo "$(date) START:REBOOT ------------------------------------------"
5054
# note: this will set an exit code of 255, which we can ignore.

0 commit comments

Comments
 (0)