This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Commit 3b5e72c
[Impeller] Round out subpass coverage. (#52973)
Resolves flutter/flutter#146967
I added a detailed comment inline explaining why we need this. The visual issues in the reported issue were due to nearest sampling while straddling a half pixel offset.
Before:

After:
<img width="964" alt="image" src="https://github.com/flutter/engine/assets/919017/0be88453-1014-443b-bc80-6df459adb075">1 parent 1a948ed commit 3b5e72c
1 file changed
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
735 | 735 | | |
736 | 736 | | |
737 | 737 | | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
738 | 754 | | |
739 | 755 | | |
740 | 756 | | |
| |||
743 | 759 | | |
744 | 760 | | |
745 | 761 | | |
746 | | - | |
747 | | - | |
748 | | - | |
749 | | - | |
| 762 | + | |
| 763 | + | |
750 | 764 | | |
751 | 765 | | |
752 | 766 | | |
| |||
0 commit comments