Correct asset variant documentation #8710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
requested review from
atsansone,
parlough and
sfshaza2
as code owners
Revert "first draft" This reverts commit e5a0b37. first draft
andrewkolos
force-pushed
the
update-asset-variants
branch
from
32f6953 to
b482605
Compare
atsansone
suggested changes
May 22, 2023
Contributor
atsansone
left a comment
atsansone
left a comment
There was a problem hiding this comment.
Fix the semantic breaks and shorten some sentences for readability.
per review comment flutter#8710 (comment) Co-authored-by: Anthony Sansone <[email protected]>
per review comment flutter#8710 (comment)
per review comment flutter#8710 (comment)
per review comment flutter#8710 (comment)
This is partly per review comment flutter#8710 (comment). Replaces awkward "requires to have". Adds missing comma before non-restrictive phrase.
per review comment flutter#8710 (comment)
andrewkolos
requested review from
domesticmouse,
johnpryan and
khanhnwin
as code owners
atsansone
added
review.tech
sfshaza2
approved these changes
Jun 6, 2023
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm! Thanks, @andrewkolos!
khanhnwin
approved these changes
Jun 6, 2023
Contributor
|
Thanks @andrewkolos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8452, updating the Adding assets and images page.
Because the idea of asset variants is limited to resolution-aware image assets, this PR deletes the outdated Asset variants section and moves the relevant information to the documentation of resolution-aware image assets.
Other things this PR does:
Presubmit checklist