Repository navigation
Drag gestures migration guide - #5771
Conversation
google-cla
Bot
added
the
cla: yes
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Other than a minor nit, LGTM. But we don't have info on where this has landed?
|
Thanks @sfshaza2! It's rolled in, but it has not gotten a build tag yet. I'm ok to wait for the tag and keep an eye on it. I'll update once I have a version #. :) |
|
@Piinks, would you mind merging the conflicts? I am a bit sleep deprived at the moment. |
There was a problem hiding this comment.
I feel like this guide is not really addressing how to migrate an app on a high-level, i.e. this is a breaking change and how do we best deal with it for whole apps?
Let's say, we have many horizontal scroll views in an app. What should be done in the migration process then? I would think it would benefit to address this choice.
- Not doing anything is not an option because it will break for many users.
- Should we override the
MaterialAppscroll behavior to allow touch drag devices everywhere? If so, we lose all benefit of this change. - Should we add the touch drag device for every horizontal scroll view?
- Potentially useful as well: why is the touch drag device not allowed for horizontal scroll views by default.
After coming back to this, I am not sure at all how this could be done :/ Maybe just take this as a "feeling" instead of actionable feedback.
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
This can't be published until a release version number is entered under "Timeline" and "Landed in version".
|
@sfshaza2 I have updated now that this has a build tag. :) 🚀 |
This adds a migration guide for the new
ScrollBehavior.dragDevicesand deprecatedGestureDetector.kind